Compare commits

..

64 commits

Author SHA1 Message Date
Darren Clarke
00d1fe5eef Update CI 2025-11-10 16:09:35 +01:00
Darren Clarke
90aad93554 Fix zammad build 2025-11-10 15:34:14 +01:00
Darren Clarke
c3881440b4 CI build fixes 2025-11-10 15:07:19 +01:00
Darren Clarke
99f8d7e2eb
Repo cleanup and updates 2025-11-10 14:55:22 +01:00
Darren Clarke
3a1063e40e Remove leafcutter and related packages 2025-11-09 12:48:12 +01:00
Darren Clarke
48165db6a2 Whatsapp unlink WIP #1 2025-11-09 11:12:04 +01:00
Darren Clarke
12b72a727c Add fix for opensearch 'flatten' indexing error 2025-11-07 13:20:30 +01:00
Darren Clarke
e3133e305c Channel filter updates 2025-11-07 11:03:06 +01:00
Darren Clarke
20078ccacc Next release WIP # 2025-10-27 21:02:19 +01:00
Darren Clarke
7d7944fa90 Formstack and Signal updates 2025-10-26 21:26:07 +01:00
Darren Clarke
f9ddc843be Updates for real form 2025-10-26 15:39:55 +01:00
Darren Clarke
6288df7cf6 Signal only WIP 2025-10-15 17:09:56 +02:00
Darren Clarke
320b9c1b38 Integration first pass 2025-10-15 16:08:53 +02:00
Darren Clarke
11563a794e Update dependencies and version number, remove link tickets endpoint 2025-10-07 11:24:00 +02:00
Darren Clarke
d9130fbaa2 Add channel filtering 2025-09-05 12:23:06 +02:00
Darren Clarke
38de035571 Add signal and whatsapp plugins 2025-09-05 11:19:20 +02:00
Darren Clarke
6f0f97ab7b Incoming filename fixes 2025-09-02 11:04:59 +02:00
Darren Clarke
d2a3c71bcd feat: Add attachment support for Signal and WhatsApp channels
- Signal: Use base64Attachments field in signal-cli-rest-api
- WhatsApp: Implement Baileys attachment sending for images, videos, audio, and documents
- Both channels retrieve attachments from Zammad Store model
- Support multiple attachments per message
2025-09-02 10:55:04 +02:00
Darren Clarke
9139c8e8de Add log level to compose files 2025-08-21 11:52:00 +02:00
Darren Clarke
7745071e63 fix: Update Dockerfiles to copy entire app directory for package dependencies
Changed Dockerfiles for bridge-frontend, link, and leafcutter to copy
the entire installer directory instead of selective copying. This ensures
all workspace packages (including @link-stack/logger) are available at
runtime, fixing the 'Cannot find package' error in Docker containers.
2025-08-20 12:58:03 +02:00
Darren Clarke
57ddcd64ea More build fixes 2025-08-20 12:30:47 +02:00
Darren Clarke
8cee269811 fix: Add missing @link-stack/logger dependency to bridge-whatsapp
The bridge-whatsapp package was importing @link-stack/logger but didn't
have it declared as a dependency, causing TypeScript build failures in CI.
2025-08-20 12:08:26 +02:00
Darren Clarke
b80faa9055 Update nvmrc and package-lock 2025-08-20 12:00:48 +02:00
Darren Clarke
c1feaa4cb1 feat: Add centralized logging system with @link-stack/logger package
- Create new @link-stack/logger package wrapping Pino for structured logging
- Replace all console.log/error/warn statements across the monorepo
- Configure environment-aware logging (pretty-print in dev, JSON in prod)
- Add automatic redaction of sensitive fields (passwords, tokens, etc.)
- Remove dead commented-out logger file from bridge-worker
- Follow Pino's standard argument order (context object first, message second)
- Support log levels via LOG_LEVEL environment variable
- Export TypeScript types for better IDE support

This provides consistent, structured logging across all applications
and packages, making debugging easier and production logs more parseable.
2025-08-20 11:37:39 +02:00
Darren Clarke
5b89bfce7c Update group name 2025-08-20 10:20:36 +02:00
Darren Clarke
75c7f3ff76 Update signal group name with Zammad ticket number 2025-08-11 16:05:35 +02:00
Darren Clarke
20ef676cf1 Fix incoming Signal messages when conversation initiated from Zammad 2025-07-25 22:39:07 +02:00
Darren Clarke
46e1116bc5 Fix internal/external group id issue 2025-07-08 18:25:44 +02:00
Darren Clarke
a55e939592 Groups WIP #2 2025-07-08 18:03:01 +02:00
Darren Clarke
7be5cb1478 More groups WIP 2025-07-07 20:02:54 +02:00
Darren Clarke
f20cd5a53c Group refinements 2025-07-02 12:07:12 +02:00
Darren Clarke
c8ccee7ada Add Signal auto-group creation 2025-06-10 14:02:21 +02:00
Darren Clarke
a83907b4be Update MUI license 2025-06-10 12:06:51 +02:00
Darren Clarke
42eb0d896c Upgrade to Zammad 6.5.0 2025-05-23 13:20:18 +02:00
Darren Clarke
3659a4ef38 Add basic READMEs 2025-05-23 13:20:07 +02:00
Darren Clarke
58e713c98b Login/logout updates 2025-03-25 10:05:52 +01:00
Darren Clarke
a35d18b5a9 Update deps 2025-03-24 11:52:38 +01:00
Darren Clarke
13a5a03860 Update login urls 2025-03-24 11:48:40 +01:00
Darren Clarke
494404c4c1 Update deps 2025-02-26 08:14:16 +01:00
Darren Clarke
05a0261355 Update deps and version numbers 2025-02-20 10:56:31 +01:00
Darren Clarke
6e8d3e171e Opensearch wrapper WIP 2025-02-17 10:53:08 +01:00
Darren Clarke
5ff5eb4213 Fix build errors 2025-02-13 10:15:38 +01:00
Darren Clarke
5a1be0de94 Merge branch 'main' into reporting 2025-02-13 09:49:55 +01:00
Darren Clarke
21cc160f8f Redis logout WIP 2025-02-05 14:09:59 +01:00
Darren Clarke
dd0265f3f5 Update deps, add robots.txt 2025-01-26 12:24:57 +01:00
Darren Clarke
810a333429 Update logging 2025-01-22 17:50:38 +01:00
Darren Clarke
def602c05e Add ioredis, update deps 2025-01-20 11:17:37 +01:00
Darren Clarke
9e5ea2fc41 Update deps and Zammad version (6.4.1) 2025-01-15 14:15:02 +01:00
Darren Clarke
07ee819520 Revert CI to use Gitlab 2025-01-08 14:19:41 +00:00
Darren Clarke
ba0f1adcc4 Fix --password-stdin 2024-12-20 11:26:25 +01:00
Darren Clarke
5af67ef6ee Use password-stdin 2024-12-20 11:13:13 +01:00
Darren Clarke
25a5f0bc68 Disable npm/turbo install 2024-12-20 09:53:45 +01:00
Darren Clarke
ab67245b91 More CI updates 2024-12-20 09:52:01 +01:00
Darren Clarke
857d877efa CI updates 2024-12-20 09:49:29 +01:00
Darren Clarke
414502a33d Install npm 10 instead of latest 2024-12-20 09:22:23 +01:00
Darren Clarke
0525f58324 Allow api calls to signal/whatsapp 2024-12-19 22:43:17 +01:00
Darren Clarke
9fb3665ced Login, logout and middleware updates 2024-12-13 16:37:20 +01:00
Darren Clarke
f552f8024f Update deps 2024-12-13 13:20:37 +01:00
Darren Clarke
589010493d Fix addon build 2024-11-28 09:37:03 +01:00
Darren Clarke
a8dd53507d Opensearch embed changes 2024-11-28 08:27:20 +01:00
Darren Clarke
130554d86b Shorten session length, change device ID calc 2024-11-25 12:20:49 +01:00
Darren Clarke
84731c9e9a Email redirect and group dropdown fixes 2024-11-25 11:48:19 +01:00
Darren Clarke
7ad25e8a95 Update dependencies 2024-11-25 09:31:25 +01:00
Darren Clarke
48aa89f7cf Make bridge worker settings configuration via env vars 2024-11-05 10:12:18 +01:00
45 changed files with 1310 additions and 1700 deletions

1
.gitignore vendored
View file

@ -30,4 +30,3 @@ project.org
**/.openapi-generator/ **/.openapi-generator/
apps/bridge-worker/scripts/* apps/bridge-worker/scripts/*
ENVIRONMENT_VARIABLES_MIGRATION.md ENVIRONMENT_VARIABLES_MIGRATION.md
local-scripts/*

View file

@ -20,13 +20,11 @@ build-all:
- turbo build - turbo build
.docker-build: .docker-build:
image: registry.gitlab.com/digiresilience/link/link-stack/buildx:main image: registry.gitlab.com/digiresilience/link/link-stack/buildx:${CI_COMMIT_REF_NAME}
services: services:
- docker:dind - docker:dind
stage: docker-build stage: docker-build
variables: variables:
DOCKER_HOST: tcp://docker:2375
DOCKER_TLS_CERTDIR: ""
DOCKER_TAG: ${CI_COMMIT_SHORT_SHA} DOCKER_TAG: ${CI_COMMIT_SHORT_SHA}
BUILD_CONTEXT: . BUILD_CONTEXT: .
only: only:
@ -39,13 +37,11 @@ build-all:
- docker push ${DOCKER_NS}:${DOCKER_TAG} - docker push ${DOCKER_NS}:${DOCKER_TAG}
.docker-release: .docker-release:
image: registry.gitlab.com/digiresilience/link/link-stack/buildx:main image: registry.gitlab.com/digiresilience/link/link-stack/buildx:${CI_COMMIT_REF_NAME}
services: services:
- docker:dind - docker:dind
stage: docker-release stage: docker-release
variables: variables:
DOCKER_HOST: tcp://docker:2375
DOCKER_TLS_CERTDIR: ""
DOCKER_TAG: ${CI_COMMIT_SHORT_SHA} DOCKER_TAG: ${CI_COMMIT_SHORT_SHA}
DOCKER_TAG_NEW: ${CI_COMMIT_REF_NAME} DOCKER_TAG_NEW: ${CI_COMMIT_REF_NAME}
only: only:
@ -199,8 +195,8 @@ zammad-docker-build:
PNPM_HOME: "/pnpm" PNPM_HOME: "/pnpm"
before_script: before_script:
- export PATH="$PNPM_HOME:$PATH" - export PATH="$PNPM_HOME:$PATH"
- corepack enable && corepack prepare pnpm@9.15.4 --activate
script: script:
- corepack enable && corepack prepare pnpm@9.15.4 --activate
- pnpm add -g turbo - pnpm add -g turbo
- pnpm install --frozen-lockfile - pnpm install --frozen-lockfile
- turbo build --force --filter @link-stack/zammad-addon-* - turbo build --force --filter @link-stack/zammad-addon-*
@ -222,8 +218,8 @@ zammad-standalone-docker-build:
PNPM_HOME: "/pnpm" PNPM_HOME: "/pnpm"
before_script: before_script:
- export PATH="$PNPM_HOME:$PATH" - export PATH="$PNPM_HOME:$PATH"
- corepack enable && corepack prepare pnpm@9.15.4 --activate
script: script:
- corepack enable && corepack prepare pnpm@9.15.4 --activate
- pnpm add -g turbo - pnpm add -g turbo
- pnpm install --frozen-lockfile - pnpm install --frozen-lockfile
- turbo build --force --filter @link-stack/zammad-addon-* - turbo build --force --filter @link-stack/zammad-addon-*

View file

@ -20,4 +20,3 @@ We use [Turborepo](https://turbo.build) to manage development and building of th
To run a single package: To run a single package:
- `turbo dev --filter @link-stack/link` - `turbo dev --filter @link-stack/link`

View file

@ -1,6 +1,6 @@
{ {
"name": "@link-stack/bridge-frontend", "name": "@link-stack/bridge-frontend",
"version": "3.3.5", "version": "3.3.0-beta.1",
"type": "module", "type": "module",
"scripts": { "scripts": {
"dev": "next dev", "dev": "next dev",
@ -20,7 +20,7 @@
"@mui/x-license": "^7", "@mui/x-license": "^7",
"@link-stack/bridge-common": "workspace:*", "@link-stack/bridge-common": "workspace:*",
"@link-stack/bridge-ui": "workspace:*", "@link-stack/bridge-ui": "workspace:*",
"next": "15.5.9", "next": "15.5.4",
"next-auth": "^4.24.11", "next-auth": "^4.24.11",
"react": "19.2.0", "react": "19.2.0",
"react-dom": "19.2.0", "react-dom": "19.2.0",

View file

@ -1,6 +1,6 @@
{ {
"name": "@link-stack/bridge-migrations", "name": "@link-stack/bridge-migrations",
"version": "3.3.5", "version": "3.3.0-beta.1",
"type": "module", "type": "module",
"scripts": { "scripts": {
"migrate:up:all": "tsx migrate.ts up:all", "migrate:up:all": "tsx migrate.ts up:all",

View file

@ -28,13 +28,10 @@ FROM base as runner
ARG BUILD_DATE ARG BUILD_DATE
ARG VERSION ARG VERSION
ARG APP_DIR=/opt/bridge-whatsapp ARG APP_DIR=/opt/bridge-whatsapp
ENV PNPM_HOME="/pnpm"
ENV PATH="$PNPM_HOME:$PATH"
RUN mkdir -p ${APP_DIR}/ RUN mkdir -p ${APP_DIR}/
RUN DEBIAN_FRONTEND=noninteractive apt-get update && \ RUN DEBIAN_FRONTEND=noninteractive apt-get update && \
apt-get install -y --no-install-recommends \ apt-get install -y --no-install-recommends \
dumb-init dumb-init
RUN corepack enable && corepack prepare pnpm@9.15.4 --activate
WORKDIR ${APP_DIR} WORKDIR ${APP_DIR}
COPY --from=installer ${APP_DIR} ./ COPY --from=installer ${APP_DIR} ./
RUN chown -R node:node ${APP_DIR} RUN chown -R node:node ${APP_DIR}

View file

@ -1,6 +1,6 @@
{ {
"name": "@link-stack/bridge-whatsapp", "name": "@link-stack/bridge-whatsapp",
"version": "3.3.5", "version": "3.3.0-beta.1",
"main": "build/main/index.js", "main": "build/main/index.js",
"author": "Darren Clarke <darren@redaranj.com>", "author": "Darren Clarke <darren@redaranj.com>",
"license": "AGPL-3.0-or-later", "license": "AGPL-3.0-or-later",
@ -11,7 +11,7 @@
"@hapipal/toys": "^4.0.0", "@hapipal/toys": "^4.0.0",
"@link-stack/bridge-common": "workspace:*", "@link-stack/bridge-common": "workspace:*",
"@link-stack/logger": "workspace:*", "@link-stack/logger": "workspace:*",
"@whiskeysockets/baileys": "6.7.21", "@whiskeysockets/baileys": "^6.7.20",
"hapi-pino": "^13.0.0", "hapi-pino": "^13.0.0",
"link-preview-js": "^3.1.0" "link-preview-js": "^3.1.0"
}, },

View file

@ -26,7 +26,11 @@ export default class WhatsappService extends Service {
connections: { [key: string]: any } = {}; connections: { [key: string]: any } = {};
loginConnections: { [key: string]: any } = {}; loginConnections: { [key: string]: any } = {};
static browserDescription: [string, string, string] = ["Bridge", "Chrome", "2.0"]; static browserDescription: [string, string, string] = [
"Bridge",
"Chrome",
"2.0",
];
constructor(server: Server, options: never) { constructor(server: Server, options: never) {
super(server, options); super(server, options);
@ -43,7 +47,7 @@ export default class WhatsappService extends Service {
} }
// Prevent path traversal by checking for suspicious patterns // Prevent path traversal by checking for suspicious patterns
if (id.includes("..") || id.includes("/") || id.includes("\\")) { if (id.includes('..') || id.includes('/') || id.includes('\\')) {
throw new Error(`Path traversal detected in bot ID: ${id}`); throw new Error(`Path traversal detected in bot ID: ${id}`);
} }
@ -98,14 +102,20 @@ export default class WhatsappService extends Service {
auth: state, auth: state,
generateHighQualityLinkPreview: false, generateHighQualityLinkPreview: false,
msgRetryCounterMap, msgRetryCounterMap,
shouldIgnoreJid: (jid) => isJidBroadcast(jid) || isJidStatusBroadcast(jid), shouldIgnoreJid: (jid) =>
isJidBroadcast(jid) || isJidStatusBroadcast(jid),
}); });
let pause = 5000; let pause = 5000;
socket.ev.process(async (events) => { socket.ev.process(async (events) => {
if (events["connection.update"]) { if (events["connection.update"]) {
const update = events["connection.update"]; const update = events["connection.update"];
const { connection: connectionState, lastDisconnect, qr, isNewLogin } = update; const {
connection: connectionState,
lastDisconnect,
qr,
isNewLogin,
} = update;
if (qr) { if (qr) {
logger.info("got qr code"); logger.info("got qr code");
const botDirectory = this.getBotDirectory(botID); const botDirectory = this.getBotDirectory(botID);
@ -120,7 +130,8 @@ export default class WhatsappService extends Service {
logger.info("opened connection"); logger.info("opened connection");
} else if (connectionState === "close") { } else if (connectionState === "close") {
logger.info({ lastDisconnect }, "connection closed"); logger.info({ lastDisconnect }, "connection closed");
const disconnectStatusCode = (lastDisconnect?.error as any)?.output?.statusCode; const disconnectStatusCode = (lastDisconnect?.error as any)?.output
?.statusCode;
if (disconnectStatusCode === DisconnectReason.restartRequired) { if (disconnectStatusCode === DisconnectReason.restartRequired) {
logger.info("reconnecting after got new login"); logger.info("reconnecting after got new login");
await this.createConnection(botID, server, options); await this.createConnection(botID, server, options);
@ -163,7 +174,10 @@ export default class WhatsappService extends Service {
const verifiedFile = `${directory}/verified`; const verifiedFile = `${directory}/verified`;
if (fs.existsSync(verifiedFile)) { if (fs.existsSync(verifiedFile)) {
const { version, isLatest } = await fetchLatestBaileysVersion(); const { version, isLatest } = await fetchLatestBaileysVersion();
logger.info({ version: version.join("."), isLatest }, "using WA version"); logger.info(
{ version: version.join("."), isLatest },
"using WA version",
);
await this.createConnection(botID, this.server, { await this.createConnection(botID, this.server, {
browser: WhatsappService.browserDescription, browser: WhatsappService.browserDescription,
@ -174,7 +188,10 @@ export default class WhatsappService extends Service {
} }
} }
private async queueMessage(botID: string, webMessageInfo: proto.IWebMessageInfo) { private async queueMessage(
botID: string,
webMessageInfo: proto.IWebMessageInfo,
) {
const { const {
key: { id, fromMe, remoteJid }, key: { id, fromMe, remoteJid },
message, message,
@ -187,9 +204,11 @@ export default class WhatsappService extends Service {
"Message field", "Message field",
); );
} }
const isValidMessage = message && remoteJid !== "status@broadcast" && !fromMe; const isValidMessage =
message && remoteJid !== "status@broadcast" && !fromMe;
if (isValidMessage) { if (isValidMessage) {
const { audioMessage, documentMessage, imageMessage, videoMessage } = message; const { audioMessage, documentMessage, imageMessage, videoMessage } =
message;
const isMediaMessage = const isMediaMessage =
audioMessage || documentMessage || imageMessage || videoMessage; audioMessage || documentMessage || imageMessage || videoMessage;
@ -269,7 +288,10 @@ export default class WhatsappService extends Service {
} }
} }
private async queueUnreadMessages(botID: string, messages: proto.IWebMessageInfo[]) { private async queueUnreadMessages(
botID: string,
messages: proto.IWebMessageInfo[],
) {
for await (const message of messages) { for await (const message of messages) {
await this.queueMessage(botID, message); await this.queueMessage(botID, message);
} }
@ -312,7 +334,10 @@ export default class WhatsappService extends Service {
} }
} }
async register(botID: string, callback?: AuthCompleteCallback): Promise<void> { async register(
botID: string,
callback?: AuthCompleteCallback,
): Promise<void> {
const { version } = await fetchLatestBaileysVersion(); const { version } = await fetchLatestBaileysVersion();
await this.createConnection( await this.createConnection(
botID, botID,
@ -330,10 +355,7 @@ export default class WhatsappService extends Service {
attachments?: Array<{ data: string; filename: string; mime_type: string }>, attachments?: Array<{ data: string; filename: string; mime_type: string }>,
): Promise<void> { ): Promise<void> {
const connection = this.connections[botID]?.socket; const connection = this.connections[botID]?.socket;
const digits = phoneNumber.replace(/\D+/g, ""); const recipient = `${phoneNumber.replace(/\D+/g, "")}@s.whatsapp.net`;
// LIDs are 15+ digits, phone numbers with country code are typically 10-14 digits
const suffix = digits.length > 14 ? "@lid" : "@s.whatsapp.net";
const recipient = `${digits}${suffix}`;
// Send text message if provided // Send text message if provided
if (message) { if (message) {
@ -346,9 +368,7 @@ export default class WhatsappService extends Service {
const MAX_TOTAL_SIZE = getMaxTotalAttachmentSize(); const MAX_TOTAL_SIZE = getMaxTotalAttachmentSize();
if (attachments.length > MAX_ATTACHMENTS) { if (attachments.length > MAX_ATTACHMENTS) {
throw new Error( throw new Error(`Too many attachments: ${attachments.length} (max ${MAX_ATTACHMENTS})`);
`Too many attachments: ${attachments.length} (max ${MAX_ATTACHMENTS})`,
);
} }
let totalSize = 0; let totalSize = 0;
@ -358,26 +378,20 @@ export default class WhatsappService extends Service {
const estimatedSize = (attachment.data.length * 3) / 4; const estimatedSize = (attachment.data.length * 3) / 4;
if (estimatedSize > MAX_ATTACHMENT_SIZE) { if (estimatedSize > MAX_ATTACHMENT_SIZE) {
logger.warn( logger.warn({
{
filename: attachment.filename, filename: attachment.filename,
size: estimatedSize, size: estimatedSize,
maxSize: MAX_ATTACHMENT_SIZE, maxSize: MAX_ATTACHMENT_SIZE
}, }, 'Attachment exceeds size limit, skipping');
"Attachment exceeds size limit, skipping",
);
continue; continue;
} }
totalSize += estimatedSize; totalSize += estimatedSize;
if (totalSize > MAX_TOTAL_SIZE) { if (totalSize > MAX_TOTAL_SIZE) {
logger.warn( logger.warn({
{
totalSize, totalSize,
maxTotalSize: MAX_TOTAL_SIZE, maxTotalSize: MAX_TOTAL_SIZE
}, }, 'Total attachment size exceeds limit, skipping remaining');
"Total attachment size exceeds limit, skipping remaining",
);
break; break;
} }

View file

@ -1,2 +1 @@
*/1 * * * * fetch-signal-messages ?max=1&id=fetchSignalMessagesCron {"scheduleTasks": "true"} */1 * * * * fetch-signal-messages ?max=1&id=fetchSignalMessagesCron {"scheduleTasks": "true"}
*/2 * * * * check-group-membership ?max=1&id=checkGroupMembershipCron {}

View file

@ -3,7 +3,7 @@ import { createLogger } from "@link-stack/logger";
import * as path from "path"; import * as path from "path";
import { fileURLToPath } from "url"; import { fileURLToPath } from "url";
const logger = createLogger("bridge-worker"); const logger = createLogger('bridge-worker');
const __filename = fileURLToPath(import.meta.url); const __filename = fileURLToPath(import.meta.url);
const __dirname = path.dirname(__filename); const __dirname = path.dirname(__filename);
@ -32,15 +32,6 @@ const main = async () => {
}; };
main().catch((err) => { main().catch((err) => {
logger.error( logger.error({ error: err }, 'Worker failed to start');
{
error: err,
message: err.message,
stack: err.stack,
name: err.name,
},
"Worker failed to start",
);
console.error("Full error:", err);
process.exit(1); process.exit(1);
}); });

View file

@ -100,57 +100,19 @@ export const Zammad = (
}; };
}; };
/** export const getUser = async (zammad: ZammadClient, phoneNumber: string) => {
* Sanitizes phone number to E.164 format: +15554446666 // Sanitize phone number: only allow digits and + symbol
* Strips all non-digit characters except +, ensures + prefix const mungedNumber = phoneNumber.replace(/[^\d+]/g, "");
* @param phoneNumber - Raw phone number (e.g., "(555) 444-6666", "5554446666", "+1 555 444 6666")
* @returns E.164 formatted phone number (e.g., "+15554446666")
* @throws Error if phone number is invalid
*/
export const sanitizePhoneNumber = (phoneNumber: string): string => {
// Remove all characters except digits and +
let cleaned = phoneNumber.replace(/[^\d+]/g, "");
// Ensure it starts with + // Validate phone number format (10-15 digits, optional + prefix)
if (!cleaned.startsWith("+")) { if (!/^\+?\d{10,15}$/.test(mungedNumber)) {
// Assume US/Canada if no country code (11 digits starting with 1, or 10 digits)
if (cleaned.length === 10) {
cleaned = "+1" + cleaned;
} else if (cleaned.length === 11 && cleaned.startsWith("1")) {
cleaned = "+" + cleaned;
} else if (cleaned.length >= 10) {
// International number without +, add it
cleaned = "+" + cleaned;
}
}
// Validate E.164 format: + followed by 10-15 digits
if (!/^\+\d{10,15}$/.test(cleaned)) {
throw new Error(`Invalid phone number format: ${phoneNumber}`); throw new Error(`Invalid phone number format: ${phoneNumber}`);
} }
return cleaned; // Remove + for search query
}; const searchNumber = mungedNumber.replace("+", "");
const results = await zammad.user.search(`phone:${searchNumber}`);
export const getUser = async (zammad: ZammadClient, phoneNumber: string) => {
// Sanitize to E.164 format
const sanitized = sanitizePhoneNumber(phoneNumber);
// Remove + for Zammad search query
const searchNumber = sanitized.replace("+", "");
// Try sanitized format first (e.g., "6464229653" for "+16464229653")
let results = await zammad.user.search(`phone:${searchNumber}`);
if (results.length > 0) return results[0]; if (results.length > 0) return results[0];
// Fall back to searching for original input (handles legacy formatted numbers)
// This ensures we can find users with "(646) 422-9653" format in database
const originalCleaned = phoneNumber.replace(/[^\d+]/g, "").replace("+", "");
if (originalCleaned !== searchNumber) {
results = await zammad.user.search(`phone:${originalCleaned}`);
if (results.length > 0) return results[0];
}
return undefined; return undefined;
}; };
@ -161,11 +123,8 @@ export const getOrCreateUser = async (
const customer = await getUser(zammad, phoneNumber); const customer = await getUser(zammad, phoneNumber);
if (customer) return customer; if (customer) return customer;
// Sanitize phone number to E.164 format before storing
const sanitized = sanitizePhoneNumber(phoneNumber);
return zammad.user.create({ return zammad.user.create({
phone: sanitized, phone: phoneNumber,
note: "User created from incoming voice call", note: "User created from incoming voice call",
}); });
}; };

View file

@ -1,6 +1,6 @@
{ {
"name": "@link-stack/bridge-worker", "name": "@link-stack/bridge-worker",
"version": "3.3.5", "version": "3.3.0-beta.1",
"type": "module", "type": "module",
"main": "build/main/index.js", "main": "build/main/index.js",
"author": "Darren Clarke <darren@redaranj.com>", "author": "Darren Clarke <darren@redaranj.com>",

View file

@ -1,121 +0,0 @@
#!/usr/bin/env node
/**
* Check Signal group membership status and update Zammad tickets
*
* This task queries the Signal CLI API to check if users have joined
* their assigned groups. When a user joins (moves from pendingInvites to members),
* it updates the ticket's group_joined flag in Zammad.
*
* Note: This task sends webhooks for all group members every time it runs.
* The Zammad webhook handler is idempotent and will ignore duplicate notifications
* if group_joined is already true.
*/
import { db, getWorkerUtils } from "@link-stack/bridge-common";
import { createLogger } from "@link-stack/logger";
import * as signalApi from "@link-stack/signal-api";
const logger = createLogger("check-group-membership");
const { Configuration, GroupsApi } = signalApi;
interface CheckGroupMembershipTaskOptions {
// Optional: Check specific group. If not provided, checks all groups with group_joined=false
groupId?: string;
botToken?: string;
}
const checkGroupMembershipTask = async (
options: CheckGroupMembershipTaskOptions = {},
): Promise<void> => {
const config = new Configuration({
basePath: process.env.BRIDGE_SIGNAL_URL,
});
const groupsClient = new GroupsApi(config);
const worker = await getWorkerUtils();
// Get all Signal bots
const bots = await db.selectFrom("SignalBot").selectAll().execute();
for (const bot of bots) {
try {
logger.debug(
{ botId: bot.id, phoneNumber: bot.phoneNumber },
"Checking groups for bot",
);
// Get all groups for this bot
const groups = await groupsClient.v1GroupsNumberGet({
number: bot.phoneNumber,
});
logger.debug(
{ botId: bot.id, groupCount: groups.length },
"Retrieved groups from Signal CLI",
);
// For each group, check if we have tickets waiting for members to join
for (const group of groups) {
if (!group.id || !group.internalId) {
logger.debug({ groupName: group.name }, "Skipping group without ID");
continue;
}
// Log info about each group temporarily for debugging
logger.info(
{
groupId: group.id,
groupName: group.name,
membersCount: group.members?.length || 0,
members: group.members,
pendingInvitesCount: group.pendingInvites?.length || 0,
pendingInvites: group.pendingInvites,
pendingRequestsCount: group.pendingRequests?.length || 0,
},
"Checking group membership",
);
// Notify Zammad about each member who has joined
// This handles both cases:
// 1. New contacts who must accept invite (they move from pendingInvites to members)
// 2. Existing contacts who are auto-added (they appear directly in members)
if (group.members && group.members.length > 0) {
for (const memberPhone of group.members) {
// Check if this member was previously pending
// We'll send the webhook and let Zammad decide if it needs to update
await worker.addJob("common/notify-webhooks", {
backendId: bot.id,
payload: {
event: "group_member_joined",
group_id: group.id,
member_phone: memberPhone,
timestamp: new Date().toISOString(),
},
});
logger.info(
{
groupId: group.id,
memberPhone,
},
"Notified Zammad about group member",
);
}
}
}
} catch (error: any) {
logger.error(
{
botId: bot.id,
error: error.message,
stack: error.stack,
},
"Error checking group membership for bot",
);
}
}
logger.info("Completed group membership check");
};
export default checkGroupMembershipTask;

View file

@ -2,7 +2,7 @@ import { db, getWorkerUtils } from "@link-stack/bridge-common";
import { createLogger } from "@link-stack/logger"; import { createLogger } from "@link-stack/logger";
import * as signalApi from "@link-stack/signal-api"; import * as signalApi from "@link-stack/signal-api";
const logger = createLogger("fetch-signal-messages"); const logger = createLogger('fetch-signal-messages');
const { Configuration, MessagesApi, AttachmentsApi } = signalApi; const { Configuration, MessagesApi, AttachmentsApi } = signalApi;
const config = new Configuration({ const config = new Configuration({
@ -28,13 +28,13 @@ const fetchAttachments = async (attachments: any[] | undefined) => {
let defaultFilename = name; let defaultFilename = name;
if (!defaultFilename) { if (!defaultFilename) {
// Check if id already has an extension // Check if id already has an extension
const hasExtension = id.includes("."); const hasExtension = id.includes('.');
if (hasExtension) { if (hasExtension) {
// ID already includes extension // ID already includes extension
defaultFilename = id; defaultFilename = id;
} else { } else {
// Add extension based on content type // Add extension based on content type
const extension = contentType?.split("/")[1] || "bin"; const extension = contentType?.split('/')[1] || 'bin';
defaultFilename = `${id}.${extension}`; defaultFilename = `${id}.${extension}`;
} }
} }
@ -64,22 +64,7 @@ const processMessage = async ({
message: msg, message: msg,
}: ProcessMessageArgs): Promise<Record<string, any>[]> => { }: ProcessMessageArgs): Promise<Record<string, any>[]> => {
const { envelope } = msg; const { envelope } = msg;
const { source, sourceUuid, dataMessage, syncMessage, receiptMessage, typingMessage } = const { source, sourceUuid, dataMessage } = envelope;
envelope;
// Log all envelope types to understand what events we're receiving
logger.info(
{
source,
sourceUuid,
hasDataMessage: !!dataMessage,
hasSyncMessage: !!syncMessage,
hasReceiptMessage: !!receiptMessage,
hasTypingMessage: !!typingMessage,
envelopeKeys: Object.keys(envelope),
},
"Received Signal envelope",
);
const isGroup = !!( const isGroup = !!(
dataMessage?.groupV2 || dataMessage?.groupV2 ||
@ -87,56 +72,12 @@ const processMessage = async ({
dataMessage?.groupInfo dataMessage?.groupInfo
); );
// Check if this is a group membership change event
const groupInfo = dataMessage?.groupInfo;
if (groupInfo) {
logger.info(
{
type: groupInfo.type,
groupId: groupInfo.groupId,
source,
groupInfoKeys: Object.keys(groupInfo),
fullGroupInfo: groupInfo,
},
"Received group info event",
);
// If user joined the group, notify Zammad
if (groupInfo.type === "JOIN" || groupInfo.type === "JOINED") {
const worker = await getWorkerUtils();
const groupId = groupInfo.groupId
? `group.${Buffer.from(groupInfo.groupId).toString("base64")}`
: null;
if (groupId) {
await worker.addJob("common/notify-webhooks", {
backendId: id,
payload: {
event: "group_member_joined",
group_id: groupId,
member_phone: source,
timestamp: new Date().toISOString(),
},
});
logger.info(
{
groupId,
memberPhone: source,
},
"User joined Signal group, notifying Zammad",
);
}
}
}
if (!dataMessage) return []; if (!dataMessage) return [];
const { attachments } = dataMessage; const { attachments } = dataMessage;
const rawTimestamp = dataMessage?.timestamp; const rawTimestamp = dataMessage?.timestamp;
logger.debug( logger.debug({
{
sourceUuid, sourceUuid,
source, source,
rawTimestamp, rawTimestamp,
@ -147,9 +88,7 @@ const processMessage = async ({
groupV2Id: dataMessage?.groupV2?.id, groupV2Id: dataMessage?.groupV2?.id,
groupContextType: dataMessage?.groupContext?.type, groupContextType: dataMessage?.groupContext?.type,
groupInfoType: dataMessage?.groupInfo?.type, groupInfoType: dataMessage?.groupInfo?.type,
}, }, 'Processing message');
"Processing message",
);
const timestamp = new Date(rawTimestamp); const timestamp = new Date(rawTimestamp);
const formattedAttachments = await fetchAttachments(attachments); const formattedAttachments = await fetchAttachments(attachments);
@ -226,7 +165,7 @@ const fetchSignalMessagesTask = async ({
number: phoneNumber, number: phoneNumber,
}); });
logger.debug({ botId: id, phoneNumber }, "Fetching messages for bot"); logger.debug({ botId: id, phoneNumber }, 'Fetching messages for bot');
for (const message of messages) { for (const message of messages) {
const formattedMessages = await processMessage({ const formattedMessages = await processMessage({
@ -236,19 +175,19 @@ const fetchSignalMessagesTask = async ({
}); });
for (const formattedMessage of formattedMessages) { for (const formattedMessage of formattedMessages) {
if (formattedMessage.to !== formattedMessage.from) { if (formattedMessage.to !== formattedMessage.from) {
logger.debug( logger.debug({
{
messageId: formattedMessage.messageId, messageId: formattedMessage.messageId,
from: formattedMessage.from, from: formattedMessage.from,
to: formattedMessage.to, to: formattedMessage.to,
isGroup: formattedMessage.isGroup, isGroup: formattedMessage.isGroup,
hasMessage: !!formattedMessage.message, hasMessage: !!formattedMessage.message,
hasAttachment: !!formattedMessage.attachment, hasAttachment: !!formattedMessage.attachment,
}, }, 'Creating job for message');
"Creating job for message",
);
await worker.addJob("signal/receive-signal-message", formattedMessage); await worker.addJob(
"signal/receive-signal-message",
formattedMessage,
);
} }
} }
} }

View file

@ -1,6 +1,5 @@
import { createLogger } from "@link-stack/logger"; import { createLogger } from "@link-stack/logger";
import { db } from "@link-stack/bridge-common"; import { Zammad, getUser } from "../../lib/zammad.js";
import { Zammad, getUser, sanitizePhoneNumber } from "../../lib/zammad.js";
import { import {
loadFieldMapping, loadFieldMapping,
getFieldValue, getFieldValue,
@ -11,7 +10,7 @@ import {
type FieldMappingConfig, type FieldMappingConfig,
} from "../../lib/formstack-field-mapping.js"; } from "../../lib/formstack-field-mapping.js";
const logger = createLogger("create-ticket-from-form"); const logger = createLogger('create-ticket-from-form');
export interface CreateTicketFromFormOptions { export interface CreateTicketFromFormOptions {
formData: any; formData: any;
@ -27,72 +26,40 @@ const createTicketFromFormTask = async (
const mapping = loadFieldMapping(); const mapping = loadFieldMapping();
// Log only non-PII metadata using configured field names // Log only non-PII metadata using configured field names
const formId = getFieldValue(formData, "formId", mapping); const formId = getFieldValue(formData, 'formId', mapping);
const uniqueId = getFieldValue(formData, "uniqueId", mapping); const uniqueId = getFieldValue(formData, 'uniqueId', mapping);
logger.info( logger.info({
{
formId, formId,
uniqueId, uniqueId,
receivedAt, receivedAt,
fieldCount: Object.keys(formData).length, fieldCount: Object.keys(formData).length
}, }, 'Processing Formstack form submission');
"Processing Formstack form submission",
);
// Extract fields using dynamic mapping // Extract fields using dynamic mapping
const nameField = getFieldValue(formData, "name", mapping); const nameField = getFieldValue(formData, 'name', mapping);
const firstName = mapping.nestedFields?.name?.firstNamePath const firstName = mapping.nestedFields?.name?.firstNamePath
? getNestedFieldValue(nameField, mapping.nestedFields.name.firstNamePath) || "" ? getNestedFieldValue(nameField, mapping.nestedFields.name.firstNamePath) || ''
: ""; : '';
const lastName = mapping.nestedFields?.name?.lastNamePath const lastName = mapping.nestedFields?.name?.lastNamePath
? getNestedFieldValue(nameField, mapping.nestedFields.name.lastNamePath) || "" ? getNestedFieldValue(nameField, mapping.nestedFields.name.lastNamePath) || ''
: ""; : '';
const fullName = const fullName = (firstName && lastName)
firstName && lastName
? `${firstName} ${lastName}`.trim() ? `${firstName} ${lastName}`.trim()
: firstName || lastName || "Unknown"; : firstName || lastName || 'Unknown';
// Extract well-known fields used for special logic (all optional) // Extract well-known fields used for special logic (all optional)
const email = getFieldValue(formData, "email", mapping); const email = getFieldValue(formData, 'email', mapping);
const rawPhone = getFieldValue(formData, "phone", mapping); const phone = getFieldValue(formData, 'phone', mapping);
const rawSignalAccount = getFieldValue(formData, "signalAccount", mapping); const signalAccount = getFieldValue(formData, 'signalAccount', mapping);
const organization = getFieldValue(formData, "organization", mapping); const organization = getFieldValue(formData, 'organization', mapping);
const typeOfSupport = getFieldValue(formData, "typeOfSupport", mapping); const typeOfSupport = getFieldValue(formData, 'typeOfSupport', mapping);
const descriptionOfIssue = getFieldValue(formData, "descriptionOfIssue", mapping); const descriptionOfIssue = getFieldValue(formData, 'descriptionOfIssue', mapping);
// Sanitize phone numbers to E.164 format (+15554446666)
let phone: string | undefined;
if (rawPhone) {
try {
phone = sanitizePhoneNumber(rawPhone);
logger.info({ rawPhone, sanitized: phone }, "Sanitized phone number");
} catch (error: any) {
logger.warn({ rawPhone, error: error.message }, "Invalid phone number format, ignoring");
phone = undefined;
}
}
let signalAccount: string | undefined;
if (rawSignalAccount) {
try {
signalAccount = sanitizePhoneNumber(rawSignalAccount);
logger.info({ rawSignalAccount, sanitized: signalAccount }, "Sanitized signal account");
} catch (error: any) {
logger.warn({ rawSignalAccount, error: error.message }, "Invalid signal account format, ignoring");
signalAccount = undefined;
}
}
// Validate that at least one contact method is provided // Validate that at least one contact method is provided
if (!email && !phone && !signalAccount) { if (!email && !phone && !signalAccount) {
logger.error( logger.error({ formId, uniqueId }, 'No contact information provided - at least one of email, phone, or signalAccount is required');
{ formId, uniqueId }, throw new Error('At least one contact method (email, phone, or signalAccount) is required for ticket creation');
"No contact information provided - at least one of email, phone, or signalAccount is required",
);
throw new Error(
"At least one contact method (email, phone, or signalAccount) is required for ticket creation",
);
} }
// Build ticket title using configured template // Build ticket title using configured template
@ -105,10 +72,10 @@ const createTicketFromFormTask = async (
// Build article body - format all fields as HTML // Build article body - format all fields as HTML
const formatAllFields = (data: any): string => { const formatAllFields = (data: any): string => {
let html = ""; let html = '';
// Add formatted name field first if we have it // Add formatted name field first if we have it
if (fullName && fullName !== "Unknown") { if (fullName && fullName !== 'Unknown') {
html += `<strong>Name:</strong><br>${fullName}<br>`; html += `<strong>Name:</strong><br>${fullName}<br>`;
} }
@ -118,17 +85,14 @@ const createTicketFromFormTask = async (
mapping.sourceFields.formId, mapping.sourceFields.formId,
mapping.sourceFields.uniqueId, mapping.sourceFields.uniqueId,
mapping.sourceFields.name, // Skip raw name field mapping.sourceFields.name, // Skip raw name field
"HandshakeKey", 'HandshakeKey',
].filter(Boolean); ].filter(Boolean);
if (skipFields.includes(key)) continue; if (skipFields.includes(key)) continue;
if (value === null || value === undefined || value === "") continue; if (value === null || value === undefined || value === '') continue;
const displayValue = Array.isArray(value) const displayValue = Array.isArray(value) ? value.join(', ') :
? value.join(", ") typeof value === 'object' ? JSON.stringify(value) : value;
: typeof value === "object"
? JSON.stringify(value)
: value;
html += `<strong>${key}:</strong><br>${displayValue}<br>`; html += `<strong>${key}:</strong><br>${displayValue}<br>`;
} }
return html; return html;
@ -137,12 +101,12 @@ const createTicketFromFormTask = async (
const body = formatAllFields(formData); const body = formatAllFields(formData);
// Get Zammad configuration from environment // Get Zammad configuration from environment
const zammadUrl = process.env.ZAMMAD_URL || "http://zammad-nginx:8080"; const zammadUrl = process.env.ZAMMAD_URL || 'http://zammad-nginx:8080';
const zammadToken = process.env.ZAMMAD_API_TOKEN; const zammadToken = process.env.ZAMMAD_API_TOKEN;
if (!zammadToken) { if (!zammadToken) {
logger.error("ZAMMAD_API_TOKEN environment variable is not configured"); logger.error('ZAMMAD_API_TOKEN environment variable is not configured');
throw new Error("ZAMMAD_API_TOKEN is required"); throw new Error('ZAMMAD_API_TOKEN is required');
} }
const zammad = Zammad({ token: zammadToken }, zammadUrl); const zammad = Zammad({ token: zammadToken }, zammadUrl);
@ -151,39 +115,35 @@ const createTicketFromFormTask = async (
// Look up the configured article type // Look up the configured article type
let articleTypeId: number | undefined; let articleTypeId: number | undefined;
try { try {
const articleTypes = await zammad.get("ticket_article_types"); const articleTypes = await zammad.get('ticket_article_types');
const configuredType = articleTypes.find( const configuredType = articleTypes.find((t: any) => t.name === mapping.ticket.defaultArticleType);
(t: any) => t.name === mapping.ticket.defaultArticleType,
);
articleTypeId = configuredType?.id; articleTypeId = configuredType?.id;
if (articleTypeId) { if (articleTypeId) {
logger.info( logger.info({ articleTypeId, typeName: mapping.ticket.defaultArticleType }, 'Found configured article type');
{ articleTypeId, typeName: mapping.ticket.defaultArticleType },
"Found configured article type",
);
} else { } else {
logger.warn( logger.warn({ typeName: mapping.ticket.defaultArticleType }, 'Configured article type not found, ticket will use default type');
{ typeName: mapping.ticket.defaultArticleType },
"Configured article type not found, ticket will use default type",
);
} }
} catch (error: any) { } catch (error: any) {
logger.warn({ error: error.message }, "Failed to look up article type"); logger.warn({ error: error.message }, 'Failed to look up article type');
} }
// Get or create user // Get or create user
// Try to find existing user by: phone -> email // Try to find existing user by: signalAccount -> phone -> email
// Note: We can't search by Signal account since Signal group IDs aren't phone numbers
let customer; let customer;
// Try phone if provided // Try Signal account first if provided
if (phone) { if (signalAccount) {
customer = await getUser(zammad, signalAccount);
if (customer) {
logger.info({ customerId: customer.id, method: 'signal' }, 'Found existing user by Signal account');
}
}
// Fall back to phone if no customer found yet
if (!customer && phone) {
customer = await getUser(zammad, phone); customer = await getUser(zammad, phone);
if (customer) { if (customer) {
logger.info( logger.info({ customerId: customer.id, method: 'phone' }, 'Found existing user by phone');
{ customerId: customer.id, method: "phone" },
"Found existing user by phone",
);
} }
} }
@ -195,25 +155,22 @@ const createTicketFromFormTask = async (
const emailResults = await zammad.user.search(`email:${email}`); const emailResults = await zammad.user.search(`email:${email}`);
if (emailResults.length > 0) { if (emailResults.length > 0) {
customer = emailResults[0]; customer = emailResults[0];
logger.info( logger.info({ customerId: customer.id, method: 'email' }, 'Found existing user by email');
{ customerId: customer.id, method: "email" },
"Found existing user by email",
);
} }
} else { } else {
logger.warn({ email }, "Invalid email format provided, skipping email search"); logger.warn({ email }, 'Invalid email format provided, skipping email search');
} }
} }
if (!customer) { if (!customer) {
// Create new user // Create new user
logger.info("Creating new user from form submission"); logger.info('Creating new user from form submission');
// Build user data with whatever contact info we have // Build user data with whatever contact info we have
const userData: any = { const userData: any = {
firstname: firstName, firstname: firstName,
lastname: lastName, lastname: lastName,
roles: ["Customer"], roles: ['Customer'],
}; };
// Add contact info only if provided // Add contact info only if provided
@ -221,129 +178,47 @@ const createTicketFromFormTask = async (
userData.email = email; userData.email = email;
} }
// Use phone number if provided (don't use Signal group ID as phone) const userPhone = signalAccount || phone;
if (phone) { if (userPhone) {
userData.phone = phone; userData.phone = userPhone;
} }
customer = await zammad.user.create(userData); customer = await zammad.user.create(userData);
} }
logger.info( logger.info({
{
customerId: customer.id, customerId: customer.id,
email: customer.email, email: customer.email,
}, }, 'Using customer for ticket');
"Using customer for ticket",
);
// Look up the configured group // Look up the configured group
const groups = await zammad.get("groups"); const groups = await zammad.get('groups');
const targetGroup = groups.find((g: any) => g.name === mapping.ticket.group); const targetGroup = groups.find((g: any) => g.name === mapping.ticket.group);
if (!targetGroup) { if (!targetGroup) {
logger.error({ groupName: mapping.ticket.group }, "Configured group not found"); logger.error({ groupName: mapping.ticket.group }, 'Configured group not found');
throw new Error(`Zammad group "${mapping.ticket.group}" not found`); throw new Error(`Zammad group "${mapping.ticket.group}" not found`);
} }
logger.info( logger.info({ groupId: targetGroup.id, groupName: targetGroup.name }, 'Using configured group');
{ groupId: targetGroup.id, groupName: targetGroup.name },
"Using configured group",
);
// Build custom fields using Zammad field mapping // Build custom fields using Zammad field mapping
// This dynamically maps all configured fields without hardcoding // This dynamically maps all configured fields without hardcoding
const customFields = getZammadFieldValues(formData, mapping); const customFields = getZammadFieldValues(formData, mapping);
// Check if this is a Signal ticket
let signalArticleType = null;
let signalChannelId = null;
let signalBotToken = null;
if (signalAccount) {
try {
logger.info({ signalAccount }, "Looking up Signal channel and article type");
// Look up Signal channels from Zammad (admin-only endpoint)
// Note: bot_token is NOT included in this response for security reasons
const channels = await zammad.get("cdr_signal_channels");
if (channels.length > 0) {
const zammadChannel = channels[0]; // Use first active Signal channel
signalChannelId = zammadChannel.id;
logger.info(
{
channelId: zammadChannel.id,
phoneNumber: zammadChannel.phone_number,
},
"Found active Signal channel from Zammad",
);
// Look up the bot_token from our own cdr database using the phone number
const signalBot = await db
.selectFrom("SignalBot")
.selectAll()
.where("phoneNumber", "=", zammadChannel.phone_number)
.executeTakeFirst();
if (signalBot) {
signalBotToken = signalBot.token;
logger.info(
{ botId: signalBot.id, phoneNumber: signalBot.phoneNumber },
"Found Signal bot token from cdr database",
);
} else {
logger.warn(
{ phoneNumber: zammadChannel.phone_number },
"Signal bot not found in cdr database",
);
}
} else {
logger.warn("No active Signal channels found");
}
// Look up cdr_signal article type
const articleTypes = await zammad.get("ticket_article_types");
signalArticleType = articleTypes.find((t: any) => t.name === "cdr_signal");
if (!signalArticleType) {
logger.warn("Signal article type (cdr_signal) not found, using default type");
} else {
logger.info(
{ articleTypeId: signalArticleType.id },
"Found Signal article type",
);
}
} catch (error: any) {
logger.warn(
{ error: error.message },
"Failed to look up Signal article type, creating regular ticket",
);
}
}
// Create the ticket // Create the ticket
const articleData: any = { const articleData: any = {
subject: descriptionOfIssue || "Support Request", subject: descriptionOfIssue || 'Support Request',
body, body,
content_type: "text/html", content_type: 'text/html',
internal: false, internal: false,
}; };
// Use Signal article type if available, otherwise use configured default if (articleTypeId) {
if (signalArticleType) {
articleData.type_id = signalArticleType.id;
logger.info({ typeId: signalArticleType.id }, "Using Signal article type");
// IMPORTANT: Set sender to "Customer" for Signal tickets created from Formstack
// This prevents the article from being echoed back to the user via Signal
// (enqueue_communicate_cdr_signal_job only sends if sender != 'Customer')
articleData.sender = "Customer";
} else if (articleTypeId) {
articleData.type_id = articleTypeId; articleData.type_id = articleTypeId;
} }
const ticketData: any = { const ticketData = {
title, title,
group_id: targetGroup.id, group_id: targetGroup.id,
customer_id: customer.id, customer_id: customer.id,
@ -351,84 +226,29 @@ const createTicketFromFormTask = async (
...customFields, ...customFields,
}; };
// Add Signal preferences if we have Signal channel and article type logger.info({
// Note: signalAccount from Formstack is the phone number the user typed in
// Groups are added later via update_group webhook from bridge-worker
if (signalChannelId && signalBotToken && signalArticleType && signalAccount) {
ticketData.preferences = {
channel_id: signalChannelId,
cdr_signal: {
bot_token: signalBotToken,
chat_id: signalAccount, // Use Signal phone number as chat_id
},
};
logger.info(
{
channelId: signalChannelId,
chatId: signalAccount,
},
"Adding Signal preferences to ticket",
);
}
logger.info(
{
title, title,
groupId: targetGroup.id, groupId: targetGroup.id,
customerId: customer.id, customerId: customer.id,
hasArticleType: !!articleTypeId || !!signalArticleType, hasArticleType: !!articleTypeId,
isSignalTicket: !!signalArticleType && !!signalAccount,
customFieldCount: Object.keys(customFields).length, customFieldCount: Object.keys(customFields).length,
}, }, 'Creating ticket');
"Creating ticket",
);
const ticket = await zammad.ticket.create(ticketData); const ticket = await zammad.ticket.create(ticketData);
// Set create_article_type_id for Signal tickets to enable proper replies logger.info({
if (signalArticleType && signalChannelId) {
try {
await zammad.ticket.update(ticket.id, {
create_article_type_id: signalArticleType.id,
});
logger.info(
{
ticketId: ticket.id,
articleTypeId: signalArticleType.id,
},
"Set create_article_type_id for Signal ticket",
);
} catch (error: any) {
logger.warn(
{
error: error.message,
ticketId: ticket.id,
},
"Failed to set create_article_type_id, ticket may not support Signal replies",
);
}
}
logger.info(
{
ticketId: ticket.id, ticketId: ticket.id,
ticketNumber: ticket.id, ticketNumber: ticket.id,
title, title,
isSignalTicket: !!signalChannelId, }, 'Successfully created ticket from Formstack submission');
},
"Successfully created ticket from Formstack submission",
);
} catch (error: any) { } catch (error: any) {
logger.error( logger.error({
{
error: error.message, error: error.message,
stack: error.stack, stack: error.stack,
formId, formId,
uniqueId, uniqueId,
}, }, 'Failed to create ticket from Formstack submission');
"Failed to create ticket from Formstack submission",
);
throw error; throw error;
} }
}; };

View file

@ -65,7 +65,8 @@ const sendSignalMessageTask = async ({
try { try {
// Check if 'to' is a group ID (UUID format, group.base64 format, or base64) vs phone number // Check if 'to' is a group ID (UUID format, group.base64 format, or base64) vs phone number
const isUUID = /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i.test( const isUUID =
/^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i.test(
to, to,
); );
const isGroupPrefix = to.startsWith("group."); const isGroupPrefix = to.startsWith("group.");
@ -78,7 +79,8 @@ const sendSignalMessageTask = async ({
to, to,
isGroupId, isGroupId,
enableAutoGroups, enableAutoGroups,
shouldCreateGroup: enableAutoGroups && !isGroupId && to && conversationId, shouldCreateGroup:
enableAutoGroups && !isGroupId && to && conversationId,
}, },
"Recipient analysis", "Recipient analysis",
); );
@ -138,7 +140,6 @@ const sendSignalMessageTask = async ({
); );
// Notify Zammad about the new group ID via webhook // Notify Zammad about the new group ID via webhook
// Set group_joined: false initially - will be updated when user accepts invitation
await worker.addJob("common/notify-webhooks", { await worker.addJob("common/notify-webhooks", {
backendId: bot.id, backendId: bot.id,
payload: { payload: {
@ -147,7 +148,6 @@ const sendSignalMessageTask = async ({
original_recipient: to, original_recipient: to,
group_id: finalTo, group_id: finalTo,
internal_group_id: internalId, internal_group_id: internalId,
group_joined: false,
timestamp: new Date().toISOString(), timestamp: new Date().toISOString(),
}, },
}); });
@ -155,7 +155,8 @@ const sendSignalMessageTask = async ({
} catch (groupError) { } catch (groupError) {
logger.error( logger.error(
{ {
error: groupError instanceof Error ? groupError.message : groupError, error:
groupError instanceof Error ? groupError.message : groupError,
to, to,
conversationId, conversationId,
}, },
@ -216,9 +217,7 @@ const sendSignalMessageTask = async ({
const MAX_TOTAL_SIZE = getMaxTotalAttachmentSize(); const MAX_TOTAL_SIZE = getMaxTotalAttachmentSize();
if (attachments.length > MAX_ATTACHMENTS) { if (attachments.length > MAX_ATTACHMENTS) {
throw new Error( throw new Error(`Too many attachments: ${attachments.length} (max ${MAX_ATTACHMENTS})`);
`Too many attachments: ${attachments.length} (max ${MAX_ATTACHMENTS})`,
);
} }
let totalSize = 0; let totalSize = 0;
@ -229,26 +228,20 @@ const sendSignalMessageTask = async ({
const estimatedSize = (attachment.data.length * 3) / 4; const estimatedSize = (attachment.data.length * 3) / 4;
if (estimatedSize > MAX_ATTACHMENT_SIZE) { if (estimatedSize > MAX_ATTACHMENT_SIZE) {
logger.warn( logger.warn({
{
filename: attachment.filename, filename: attachment.filename,
size: estimatedSize, size: estimatedSize,
maxSize: MAX_ATTACHMENT_SIZE, maxSize: MAX_ATTACHMENT_SIZE
}, }, 'Attachment exceeds size limit, skipping');
"Attachment exceeds size limit, skipping",
);
continue; continue;
} }
totalSize += estimatedSize; totalSize += estimatedSize;
if (totalSize > MAX_TOTAL_SIZE) { if (totalSize > MAX_TOTAL_SIZE) {
logger.warn( logger.warn({
{
totalSize, totalSize,
maxTotalSize: MAX_TOTAL_SIZE, maxTotalSize: MAX_TOTAL_SIZE
}, }, 'Total attachment size exceeds limit, skipping remaining');
"Total attachment size exceeds limit, skipping remaining",
);
break; break;
} }
@ -260,10 +253,8 @@ const sendSignalMessageTask = async ({
logger.debug( logger.debug(
{ {
attachmentCount: validatedAttachments.length, attachmentCount: validatedAttachments.length,
attachmentNames: attachments attachmentNames: attachments.slice(0, validatedAttachments.length).map((att) => att.filename),
.slice(0, validatedAttachments.length) totalSizeBytes: totalSize
.map((att) => att.filename),
totalSizeBytes: totalSize,
}, },
"Including attachments in message", "Including attachments in message",
); );

View file

@ -1,6 +1,6 @@
{ {
"name": "@link-stack/link", "name": "@link-stack/link",
"version": "3.3.5", "version": "3.3.0-beta.1",
"type": "module", "type": "module",
"scripts": { "scripts": {
"dev": "next dev -H 0.0.0.0", "dev": "next dev -H 0.0.0.0",
@ -31,7 +31,7 @@
"graphql-request": "^7.2.0", "graphql-request": "^7.2.0",
"ioredis": "^5.8.1", "ioredis": "^5.8.1",
"mui-chips-input": "^6.0.0", "mui-chips-input": "^6.0.0",
"next": "15.5.9", "next": "15.5.4",
"next-auth": "^4.24.11", "next-auth": "^4.24.11",
"react": "19.2.0", "react": "19.2.0",
"react-cookie": "^8.0.1", "react-cookie": "^8.0.1",

View file

@ -0,0 +1,67 @@
version: '3.8'
services:
zammad-railsserver:
volumes:
# Controllers
- ${PWD}/packages/zammad-addon-bridge/src/app/controllers/channels_cdr_signal_controller.rb:/opt/zammad/app/controllers/channels_cdr_signal_controller.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/app/controllers/channels_cdr_voice_controller.rb:/opt/zammad/app/controllers/channels_cdr_voice_controller.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/app/controllers/channels_cdr_whatsapp_controller.rb:/opt/zammad/app/controllers/channels_cdr_whatsapp_controller.rb:ro
# Models
- ${PWD}/packages/zammad-addon-bridge/src/app/models/channel/driver/cdr_signal.rb:/opt/zammad/app/models/channel/driver/cdr_signal.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/app/models/channel/driver/cdr_whatsapp.rb:/opt/zammad/app/models/channel/driver/cdr_whatsapp.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/app/models/ticket/article/enqueue_communicate_cdr_signal_job.rb:/opt/zammad/app/models/ticket/article/enqueue_communicate_cdr_signal_job.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/app/models/ticket/article/enqueue_communicate_cdr_whatsapp_job.rb:/opt/zammad/app/models/ticket/article/enqueue_communicate_cdr_whatsapp_job.rb:ro
# Jobs
- ${PWD}/packages/zammad-addon-bridge/src/app/jobs/communicate_cdr_signal_job.rb:/opt/zammad/app/jobs/communicate_cdr_signal_job.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/app/jobs/communicate_cdr_whatsapp_job.rb:/opt/zammad/app/jobs/communicate_cdr_whatsapp_job.rb:ro
# Policies
- ${PWD}/packages/zammad-addon-bridge/src/app/policies/controllers/channels_cdr_signal_controller_policy.rb:/opt/zammad/app/policies/controllers/channels_cdr_signal_controller_policy.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/app/policies/controllers/channels_cdr_voice_controller_policy.rb:/opt/zammad/app/policies/controllers/channels_cdr_voice_controller_policy.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/app/policies/controllers/channels_cdr_whatsapp_controller_policy.rb:/opt/zammad/app/policies/controllers/channels_cdr_whatsapp_controller_policy.rb:ro
# Config - initializers
- ${PWD}/packages/zammad-addon-bridge/src/config/initializers/cdr_signal.rb:/opt/zammad/config/initializers/cdr_signal.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/config/initializers/cdr_whatsapp.rb:/opt/zammad/config/initializers/cdr_whatsapp.rb:ro
# Config - routes
- ${PWD}/packages/zammad-addon-bridge/src/config/routes/channel_cdr_signal.rb:/opt/zammad/config/routes/channel_cdr_signal.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/config/routes/channel_cdr_voice.rb:/opt/zammad/config/routes/channel_cdr_voice.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/config/routes/channel_cdr_whatsapp.rb:/opt/zammad/config/routes/channel_cdr_whatsapp.rb:ro
# Database migrations
- ${PWD}/packages/zammad-addon-bridge/src/db/addon/bridge/20210525091356_cdr_signal_channel.rb:/opt/zammad/db/addon/bridge/20210525091356_cdr_signal_channel.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/db/addon/bridge/20210525091357_cdr_voice_channel.rb:/opt/zammad/db/addon/bridge/20210525091357_cdr_voice_channel.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/db/addon/bridge/20210525091358_cdr_whatsapp_channel.rb:/opt/zammad/db/addon/bridge/20210525091358_cdr_whatsapp_channel.rb:ro
# Lib files
- ${PWD}/packages/zammad-addon-bridge/src/lib/cdr_signal.rb:/opt/zammad/lib/cdr_signal.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/lib/cdr_signal_api.rb:/opt/zammad/lib/cdr_signal_api.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/lib/cdr_whatsapp.rb:/opt/zammad/lib/cdr_whatsapp.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/lib/cdr_whatsapp_api.rb:/opt/zammad/lib/cdr_whatsapp_api.rb:ro
# Also map to scheduler for background jobs
zammad-scheduler:
volumes:
# Models
- ${PWD}/packages/zammad-addon-bridge/src/app/models/channel/driver/cdr_signal.rb:/opt/zammad/app/models/channel/driver/cdr_signal.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/app/models/channel/driver/cdr_whatsapp.rb:/opt/zammad/app/models/channel/driver/cdr_whatsapp.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/app/models/ticket/article/enqueue_communicate_cdr_signal_job.rb:/opt/zammad/app/models/ticket/article/enqueue_communicate_cdr_signal_job.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/app/models/ticket/article/enqueue_communicate_cdr_whatsapp_job.rb:/opt/zammad/app/models/ticket/article/enqueue_communicate_cdr_whatsapp_job.rb:ro
# Jobs
- ${PWD}/packages/zammad-addon-bridge/src/app/jobs/communicate_cdr_signal_job.rb:/opt/zammad/app/jobs/communicate_cdr_signal_job.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/app/jobs/communicate_cdr_whatsapp_job.rb:/opt/zammad/app/jobs/communicate_cdr_whatsapp_job.rb:ro
# Config - initializers
- ${PWD}/packages/zammad-addon-bridge/src/config/initializers/cdr_signal.rb:/opt/zammad/config/initializers/cdr_signal.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/config/initializers/cdr_whatsapp.rb:/opt/zammad/config/initializers/cdr_whatsapp.rb:ro
# Lib files
- ${PWD}/packages/zammad-addon-bridge/src/lib/cdr_signal.rb:/opt/zammad/lib/cdr_signal.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/lib/cdr_signal_api.rb:/opt/zammad/lib/cdr_signal_api.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/lib/cdr_whatsapp.rb:/opt/zammad/lib/cdr_whatsapp.rb:ro
- ${PWD}/packages/zammad-addon-bridge/src/lib/cdr_whatsapp_api.rb:/opt/zammad/lib/cdr_whatsapp_api.rb:ro

View file

@ -1,20 +0,0 @@
services:
bridge-whatsapp:
container_name: bridge-whatsapp
build:
context: ../../
dockerfile: ./apps/bridge-whatsapp/Dockerfile
image: registry.gitlab.com/digiresilience/link/link-stack/bridge-whatsapp:${LINK_STACK_VERSION}
restart: ${RESTART}
environment:
PORT: 5000
NODE_ENV: production
BRIDGE_FRONTEND_URL: http://link:3000/link
volumes:
- bridge-whatsapp-data:/home/node/baileys
ports:
- 5000:5000
volumes:
bridge-whatsapp-data:
driver: local

View file

@ -22,7 +22,6 @@ x-bridge-vars: &common-bridge-variables
NEXTAUTH_SECRET: ${NEXTAUTH_SECRET} NEXTAUTH_SECRET: ${NEXTAUTH_SECRET}
BRIDGE_SIGNAL_URL: ${BRIDGE_SIGNAL_URL} BRIDGE_SIGNAL_URL: ${BRIDGE_SIGNAL_URL}
BRIDGE_SIGNAL_AUTO_GROUPS: ${BRIDGE_SIGNAL_AUTO_GROUPS} BRIDGE_SIGNAL_AUTO_GROUPS: ${BRIDGE_SIGNAL_AUTO_GROUPS}
BRIDGE_WHATSAPP_URL: "http://bridge-whatsapp:5000"
LOG_LEVEL: "debug" LOG_LEVEL: "debug"
ZAMMAD_API_TOKEN: ${ZAMMAD_API_TOKEN} ZAMMAD_API_TOKEN: ${ZAMMAD_API_TOKEN}
ZAMMAD_URL: ${ZAMMAD_URL} ZAMMAD_URL: ${ZAMMAD_URL}

View file

@ -16,7 +16,7 @@ services:
LINK_URL: ${LINK_URL} LINK_URL: ${LINK_URL}
BRIDGE_URL: http://bridge-frontend:3000 BRIDGE_URL: http://bridge-frontend:3000
BRIDGE_SIGNAL_URL: http://signal-cli-rest-api:8080 BRIDGE_SIGNAL_URL: http://signal-cli-rest-api:8080
BRIDGE_WHATSAPP_URL: http://bridge-whatsapp:5000 BRIDGE_WHATSAPP_URL: http://bridge-whatsapp:3000
ZAMMAD_URL: http://zammad-nginx:8080 ZAMMAD_URL: http://zammad-nginx:8080
REDIS_URL: "redis://zammad-redis:6379" REDIS_URL: "redis://zammad-redis:6379"
NEXTAUTH_URL: ${LINK_URL}/api/auth NEXTAUTH_URL: ${LINK_URL}/api/auth

View file

@ -56,6 +56,9 @@ RUN sed -i "s/'flattened'/'flat_object'/g" /opt/zammad/lib/search_index_backend.
RUN touch db/schema.rb && \ RUN touch db/schema.rb && \
ZAMMAD_SAFE_MODE=1 DATABASE_URL=postgresql://zammad:/zammad bundle exec rake assets:precompile ZAMMAD_SAFE_MODE=1 DATABASE_URL=postgresql://zammad:/zammad bundle exec rake assets:precompile
# Run additional setup for addons
RUN bundle exec rails runner /opt/zammad/contrib/link/setup.rb || true
# Clean up build artifacts # Clean up build artifacts
RUN rm -rf tmp/cache node_modules/.cache RUN rm -rf tmp/cache node_modules/.cache
ARG EMBEDDED=false ARG EMBEDDED=false
@ -75,14 +78,6 @@ RUN if [ "$EMBEDDED" = "true" ] ; then \
echo "}" >> /opt/zammad/contrib/nginx/zammad.conf; \ echo "}" >> /opt/zammad/contrib/nginx/zammad.conf; \
fi fi
# Modify entrypoint to install packages and run migrations at runtime
RUN sed -i '/^[[:space:]]*# es config/a\
echo "Installing addon packages..."\n\
bundle exec rails runner /opt/zammad/contrib/link/setup.rb\n\
bundle exec rake zammad:package:migrate\n\
' /docker-entrypoint.sh
FROM zammad/zammad-docker-compose:${ZAMMAD_VERSION} AS runner FROM zammad/zammad-docker-compose:${ZAMMAD_VERSION} AS runner
USER root USER root
@ -93,7 +88,37 @@ RUN apt-get update && \
rm -rf /var/lib/apt/lists/* && \ rm -rf /var/lib/apt/lists/* && \
npm install -g pnpm npm install -g pnpm
USER zammad # Copy only the modified/added files from builder
COPY --from=builder --chown=zammad:zammad ${ZAMMAD_DIR} ${ZAMMAD_DIR} # Copy addon files that were installed
COPY --from=builder /usr/local/bundle /usr/local/bundle COPY --from=builder --chown=zammad:zammad /opt/zammad/app/frontend/apps/desktop/pages/ticket/components/TicketDetailView/ /opt/zammad/app/frontend/apps/desktop/pages/ticket/components/TicketDetailView/
COPY --from=builder --chown=zammad:zammad /opt/zammad/app/frontend/shared/entities/ticket-article/action/plugins/ /opt/zammad/app/frontend/shared/entities/ticket-article/action/plugins/
COPY --from=builder --chown=zammad:zammad /opt/zammad/db/addon/ /opt/zammad/db/addon/
COPY --from=builder --chown=zammad:zammad /opt/zammad/app/assets/ /opt/zammad/app/assets/
COPY --from=builder --chown=zammad:zammad /opt/zammad/app/controllers/*cdr* /opt/zammad/app/controllers/
COPY --from=builder --chown=zammad:zammad /opt/zammad/app/jobs/*cdr* /opt/zammad/app/jobs/
COPY --from=builder --chown=zammad:zammad /opt/zammad/app/models/channel/driver/*cdr* /opt/zammad/app/models/channel/driver/
COPY --from=builder --chown=zammad:zammad /opt/zammad/app/models/ticket/article/*cdr* /opt/zammad/app/models/ticket/article/
COPY --from=builder --chown=zammad:zammad /opt/zammad/app/policies/controllers/*cdr* /opt/zammad/app/policies/controllers/
COPY --from=builder --chown=zammad:zammad /opt/zammad/config/initializers/*cdr* /opt/zammad/config/initializers/
COPY --from=builder --chown=zammad:zammad /opt/zammad/config/routes/*cdr* /opt/zammad/config/routes/
COPY --from=builder --chown=zammad:zammad /opt/zammad/lib/cdr* /opt/zammad/lib/
# CRITICAL: Copy modified search_index_backend.rb with OpenSearch fix
COPY --from=builder --chown=zammad:zammad /opt/zammad/lib/search_index_backend.rb /opt/zammad/lib/search_index_backend.rb
COPY --from=builder --chown=zammad:zammad /opt/zammad/public/assets/images/icons/*cdr* /opt/zammad/public/assets/images/icons/
COPY --from=builder --chown=zammad:zammad /opt/zammad/app/views/mailer/ticket_create/ /opt/zammad/app/views/mailer/ticket_create/
COPY --from=builder --chown=zammad:zammad /opt/zammad/public/assets/images/logo* /opt/zammad/public/assets/images/
# Copy the nginx config if embedded mode was used
COPY --from=builder --chown=zammad:zammad /opt/zammad/contrib/nginx/zammad.conf /opt/zammad/contrib/nginx/zammad.conf
# Copy the link setup scripts and addons
COPY --from=builder --chown=zammad:zammad /opt/zammad/contrib/link/ /opt/zammad/contrib/link/
# CRITICAL: Copy compiled assets that include our CoffeeScript changes
# The builder stage compiles assets at line 47, we must copy them to runner
COPY --from=builder --chown=zammad:zammad /opt/zammad/public/assets/ /opt/zammad/public/assets/
# Copy the modified entrypoint script
COPY --from=builder /docker-entrypoint.sh /docker-entrypoint.sh COPY --from=builder /docker-entrypoint.sh /docker-entrypoint.sh
USER zammad

View file

@ -1,6 +1,6 @@
{ {
"name": "@link-stack", "name": "@link-stack",
"version": "3.3.5", "version": "3.3.0-beta.1",
"description": "Link from the Center for Digital Resilience", "description": "Link from the Center for Digital Resilience",
"scripts": { "scripts": {
"dev": "dotenv -- turbo dev", "dev": "dotenv -- turbo dev",

View file

@ -1,12 +1,19 @@
import { PostgresDialect, CamelCasePlugin } from "kysely"; import { PostgresDialect, CamelCasePlugin } from "kysely";
import type { GeneratedAlways, Generated, ColumnType, Selectable } from "kysely"; import type {
GeneratedAlways,
Generated,
ColumnType,
Selectable,
} from "kysely";
import pg from "pg"; import pg from "pg";
import { KyselyAuth } from "@auth/kysely-adapter"; import { KyselyAuth } from "@auth/kysely-adapter";
const { Pool, types } = pg; const { Pool, types } = pg;
type Timestamp = ColumnType<Date, Date | string>; type Timestamp = ColumnType<Date, Date | string>;
types.setTypeParser(types.builtins.TIMESTAMPTZ, (val) => new Date(val).toISOString()); types.setTypeParser(types.builtins.TIMESTAMPTZ, (val) =>
new Date(val).toISOString(),
);
type GraphileJob = { type GraphileJob = {
taskIdentifier: string; taskIdentifier: string;
@ -146,23 +153,13 @@ function getDb(): KyselyAuth<Database> {
const DATABASE_USER = process.env.DATABASE_USER; const DATABASE_USER = process.env.DATABASE_USER;
const DATABASE_PASSWORD = process.env.DATABASE_PASSWORD; const DATABASE_PASSWORD = process.env.DATABASE_PASSWORD;
if ( if (!DATABASE_HOST || !DATABASE_NAME || !DATABASE_PORT || !DATABASE_USER || !DATABASE_PASSWORD) {
!DATABASE_HOST || throw new Error('Missing required database environment variables: DATABASE_HOST, DATABASE_NAME, DATABASE_PORT, DATABASE_USER, DATABASE_PASSWORD');
!DATABASE_NAME ||
!DATABASE_PORT ||
!DATABASE_USER ||
!DATABASE_PASSWORD
) {
throw new Error(
"Missing required database environment variables: DATABASE_HOST, DATABASE_NAME, DATABASE_PORT, DATABASE_USER, DATABASE_PASSWORD",
);
} }
const port = parseInt(DATABASE_PORT, 10); const port = parseInt(DATABASE_PORT, 10);
if (isNaN(port) || port < 1 || port > 65535) { if (isNaN(port) || port < 1 || port > 65535) {
throw new Error( throw new Error(`Invalid DATABASE_PORT: ${DATABASE_PORT}. Must be a number between 1 and 65535.`);
`Invalid DATABASE_PORT: ${DATABASE_PORT}. Must be a number between 1 and 65535.`,
);
} }
_db = new KyselyAuth<Database>({ _db = new KyselyAuth<Database>({
@ -188,7 +185,7 @@ export const db = new Proxy({} as KyselyAuth<Database>, {
const value = (instance as any)[prop]; const value = (instance as any)[prop];
// If it's a function, bind it to the actual instance to preserve 'this' context // If it's a function, bind it to the actual instance to preserve 'this' context
if (typeof value === "function") { if (typeof value === 'function') {
return value.bind(instance); return value.bind(instance);
} }

View file

@ -1,6 +1,6 @@
{ {
"name": "@link-stack/bridge-common", "name": "@link-stack/bridge-common",
"version": "3.3.5", "version": "3.3.0-beta.1",
"main": "build/main/index.js", "main": "build/main/index.js",
"type": "module", "type": "module",
"author": "Darren Clarke <darren@redaranj.com>", "author": "Darren Clarke <darren@redaranj.com>",

View file

@ -29,30 +29,21 @@ export const QRCode: FC<QRCodeProps> = ({
useEffect(() => { useEffect(() => {
if (!verified && getValue && refreshInterval) { if (!verified && getValue && refreshInterval) {
// Fetch immediately on mount const interval = setInterval(async () => {
const fetchQR = async () => {
const { qr, kind } = await getValue(token); const { qr, kind } = await getValue(token);
setValue(qr); setValue(qr);
setKind(kind); setKind(kind);
}; }, refreshInterval * 1000);
fetchQR();
// Then set up interval for refreshes
const interval = setInterval(fetchQR, refreshInterval * 1000);
return () => clearInterval(interval); return () => clearInterval(interval);
} }
}, [getValue, refreshInterval, token, verified]); }, [getValue, refreshInterval]);
return !verified ? ( return !verified ? (
<Box sx={{ backgroundColor: white, m: 2 }}> <Box sx={{ backgroundColor: white, m: 2 }}>
{value ? ( {kind === "data" ? (
kind === "data" ? (
<QRCodeInternal value={value} /> <QRCodeInternal value={value} />
) : ( ) : (
<img src={value} alt={name} /> <img src={value} alt={name} />
)
) : (
<Box>Loading QR code...</Box>
)} )}
<Box>{helperText}</Box> <Box>{helperText}</Box>
</Box> </Box>

View file

@ -2,28 +2,11 @@ import { ServiceConfig } from "../lib/service";
// import { generateSelectOneAction } from "../lib/actions"; // import { generateSelectOneAction } from "../lib/actions";
const getQRCode = async (token: string) => { const getQRCode = async (token: string) => {
try {
const url = `/link/api/whatsapp/bots/${token}`; const url = `/link/api/whatsapp/bots/${token}`;
const result = await fetch(url, { cache: "no-store" }); const result = await fetch(url, { cache: "no-store" });
const { qr } = await result.json();
if (!result.ok) {
console.error(`Failed to fetch QR code: ${result.status} ${result.statusText}`);
return { qr: "", kind: "data" };
}
const data = await result.json();
const { qr } = data;
if (!qr) {
console.error("No QR code in response");
return { qr: "", kind: "data" };
}
return { qr, kind: "data" }; return { qr, kind: "data" };
} catch (error) {
console.error("Error fetching QR code:", error);
return { qr: "", kind: "data" };
}
}; };
export const whatsappConfig: ServiceConfig = { export const whatsappConfig: ServiceConfig = {

View file

@ -1,6 +1,6 @@
{ {
"name": "@link-stack/bridge-ui", "name": "@link-stack/bridge-ui",
"version": "3.3.5", "version": "3.3.0-beta.1",
"scripts": { "scripts": {
"build": "tsc -p tsconfig.json" "build": "tsc -p tsconfig.json"
}, },
@ -11,7 +11,7 @@
"@mui/material": "^6", "@mui/material": "^6",
"@mui/x-data-grid-pro": "^7", "@mui/x-data-grid-pro": "^7",
"kysely": "0.27.5", "kysely": "0.27.5",
"next": "15.5.9", "next": "15.5.4",
"react": "19.2.0", "react": "19.2.0",
"react-dom": "19.2.0", "react-dom": "19.2.0",
"react-qr-code": "^2.0.18" "react-qr-code": "^2.0.18"

View file

@ -1,6 +1,6 @@
{ {
"name": "@link-stack/eslint-config", "name": "@link-stack/eslint-config",
"version": "3.3.5", "version": "3.3.0-beta.1",
"description": "amigo's eslint config", "description": "amigo's eslint config",
"main": "index.js", "main": "index.js",
"author": "Abel Luck <abel@guardianproject.info>", "author": "Abel Luck <abel@guardianproject.info>",

View file

@ -1,6 +1,6 @@
{ {
"name": "@link-stack/jest-config", "name": "@link-stack/jest-config",
"version": "3.3.5", "version": "3.3.0-beta.1",
"description": "", "description": "",
"main": "index.js", "main": "index.js",
"author": "Abel Luck <abel@guardianproject.info>", "author": "Abel Luck <abel@guardianproject.info>",

View file

@ -1,6 +1,6 @@
{ {
"name": "@link-stack/logger", "name": "@link-stack/logger",
"version": "3.3.5", "version": "3.3.0-beta.1",
"description": "Shared logging utility for Link Stack monorepo", "description": "Shared logging utility for Link Stack monorepo",
"main": "./dist/index.js", "main": "./dist/index.js",
"module": "./dist/index.mjs", "module": "./dist/index.mjs",

View file

@ -1,6 +1,6 @@
{ {
"name": "@link-stack/signal-api", "name": "@link-stack/signal-api",
"version": "3.3.5", "version": "3.3.0-beta.1",
"type": "module", "type": "module",
"main": "build/index.js", "main": "build/index.js",
"exports": { "exports": {

View file

@ -1,6 +1,6 @@
{ {
"name": "@link-stack/typescript-config", "name": "@link-stack/typescript-config",
"version": "3.3.5", "version": "3.3.0-beta.1",
"description": "Shared TypeScript config", "description": "Shared TypeScript config",
"license": "AGPL-3.0-or-later", "license": "AGPL-3.0-or-later",
"author": "Abel Luck <abel@guardianproject.info>", "author": "Abel Luck <abel@guardianproject.info>",

View file

@ -1,6 +1,6 @@
{ {
"name": "@link-stack/ui", "name": "@link-stack/ui",
"version": "3.3.5", "version": "3.3.0-beta.1",
"description": "", "description": "",
"scripts": { "scripts": {
"build": "tsc -p tsconfig.json" "build": "tsc -p tsconfig.json"
@ -11,7 +11,7 @@
"@mui/material": "^6", "@mui/material": "^6",
"@mui/x-data-grid-pro": "^7", "@mui/x-data-grid-pro": "^7",
"@mui/x-license": "^7", "@mui/x-license": "^7",
"next": "15.5.9", "next": "15.5.4",
"react": "19.2.0", "react": "19.2.0",
"react-dom": "19.2.0" "react-dom": "19.2.0"
}, },

View file

@ -1,7 +1,7 @@
{ {
"name": "@link-stack/zammad-addon-bridge", "name": "@link-stack/zammad-addon-bridge",
"displayName": "Bridge", "displayName": "Bridge",
"version": "3.3.5", "version": "3.3.0-beta.1",
"description": "An addon that adds CDR Bridge channels to Zammad.", "description": "An addon that adds CDR Bridge channels to Zammad.",
"scripts": { "scripts": {
"build": "node '../zammad-addon-common/dist/build.js'", "build": "node '../zammad-addon-common/dist/build.js'",

View file

@ -45,6 +45,13 @@ class CdrWhatsappReply
@articleTypes: (articleTypes, ticket, ui) -> @articleTypes: (articleTypes, ticket, ui) ->
return articleTypes if !ui.permissionCheck('ticket.agent') return articleTypes if !ui.permissionCheck('ticket.agent')
# Check CDR Link allowed channels setting
allowedChannels = ui.Config.get('cdr_link_allowed_channels')
if allowedChannels && allowedChannels.trim()
whitelist = (channel.trim() for channel in allowedChannels.split(','))
# Return early if 'cdr_whatsapp' or 'whatsapp message' not in whitelist
return articleTypes if 'cdr_whatsapp' not in whitelist && 'whatsapp message' not in whitelist
return articleTypes if !ticket || !ticket.create_article_type_id return articleTypes if !ticket || !ticket.create_article_type_id
articleTypeCreate = App.TicketArticleType.find(ticket.create_article_type_id).name articleTypeCreate = App.TicketArticleType.find(ticket.create_article_type_id).name

View file

@ -1,18 +0,0 @@
# frozen_string_literal: true
class CdrSignalChannelsController < ApplicationController
prepend_before_action -> { authentication_check && authorize! }
def index
channels = Channel.where(area: 'Signal::Number', active: true).map do |channel|
{
id: channel.id,
phone_number: channel.options['phone_number'],
bot_endpoint: channel.options['bot_endpoint']
# bot_token intentionally excluded - bridge-worker should look it up from cdr database
}
end
render json: channels
end
end

View file

@ -115,22 +115,13 @@ class ChannelsCdrSignalController < ApplicationController
channel = channel_for_token(token) channel = channel_for_token(token)
return render json: {}, status: 401 if !channel || !channel.active return render json: {}, status: 401 if !channel || !channel.active
# Use constant-time comparison to prevent timing attacks return render json: {}, status: 401 if channel.options[:token] != token
return render json: {}, status: 401 unless ActiveSupport::SecurityUtils.secure_compare(
channel.options[:token].to_s,
token.to_s
)
# Handle group creation events # Handle group creation events
if params[:event] == 'group_created' if params[:event] == 'group_created'
return update_group return update_group
end end
# Handle group member joined events
if params[:event] == 'group_member_joined'
return handle_group_member_joined
end
channel_id = channel.id channel_id = channel.id
# validate input # validate input
@ -222,13 +213,38 @@ class ChannelsCdrSignalController < ApplicationController
Rails.logger.info "Channel ID: #{channel.id}" Rails.logger.info "Channel ID: #{channel.id}"
begin begin
# Use text search on preferences YAML to efficiently find tickets without loading all into memory # For group messages, search all tickets regardless of customer
# This prevents DoS attacks from memory exhaustion # since users may have duplicate phone numbers
ticket = Ticket.where.not(state_id: state_ids) all_tickets = Ticket.where.not(state_id: state_ids)
.where("preferences LIKE ?", "%channel_id: #{channel.id}%")
.where("preferences LIKE ?", "%chat_id: #{receiver_phone_number}%")
.order(updated_at: :desc) .order(updated_at: :desc)
.first
Rails.logger.info "Found #{all_tickets.count} active tickets (searching all customers for group match)"
ticket = all_tickets.find do |t|
begin
has_preferences = t.preferences.is_a?(Hash)
has_cdr_signal = has_preferences && t.preferences['cdr_signal'].is_a?(Hash)
has_channel_id = has_preferences && t.preferences['channel_id'] == channel.id
if has_cdr_signal && has_channel_id
stored_chat_id = t.preferences['cdr_signal']['chat_id']
Rails.logger.info " - stored_chat_id: #{stored_chat_id}"
Rails.logger.info " - incoming_group_id: #{receiver_phone_number}"
matches = receiver_phone_number == stored_chat_id
Rails.logger.info " - MATCH: #{matches}"
matches
else
Rails.logger.info "Ticket ##{t.number} has no cdr_signal preferences or wrong channel"
false
end
rescue => e
Rails.logger.error "Error checking ticket #{t.id}: #{e.message}"
false
end
end
if ticket if ticket
Rails.logger.info "=== FOUND MATCHING TICKET BY GROUP ID: ##{ticket.number} ===" Rails.logger.info "=== FOUND MATCHING TICKET BY GROUP ID: ##{ticket.number} ==="
@ -381,10 +397,6 @@ class ChannelsCdrSignalController < ApplicationController
ticket.preferences[:cdr_signal][:original_recipient] = params[:original_recipient] if params[:original_recipient].present? ticket.preferences[:cdr_signal][:original_recipient] = params[:original_recipient] if params[:original_recipient].present?
ticket.preferences[:cdr_signal][:group_created_at] = params[:timestamp] if params[:timestamp].present? ticket.preferences[:cdr_signal][:group_created_at] = params[:timestamp] if params[:timestamp].present?
# Track whether user has joined the group (initially false)
# This will be updated to true when we receive a group join event from Signal
ticket.preferences[:cdr_signal][:group_joined] = params[:group_joined] if params.key?(:group_joined)
ticket.save! ticket.save!
Rails.logger.info "Signal group #{params[:group_id]} associated with ticket #{ticket.id}" Rails.logger.info "Signal group #{params[:group_id]} associated with ticket #{ticket.id}"
@ -395,74 +407,4 @@ class ChannelsCdrSignalController < ApplicationController
ticket_number: ticket.number ticket_number: ticket.number
}, status: :ok }, status: :ok
end end
# Webhook endpoint for receiving group member joined notifications from bridge-worker
# This is called when a user accepts the Signal group invitation
# Expected payload:
# {
# "event": "group_member_joined",
# "group_id": "group.base64encodedid",
# "member_phone": "+1234567890",
# "timestamp": "ISO8601 timestamp"
# }
def handle_group_member_joined
# Validate required parameters
errors = {}
errors['event'] = 'required' unless params[:event].present?
errors['group_id'] = 'required' unless params[:group_id].present?
errors['member_phone'] = 'required' unless params[:member_phone].present?
if errors.present?
render json: {
errors: errors
}, status: :bad_request
return
end
# Find ticket(s) with this group_id in preferences
# Use text search on preferences YAML for efficient lookup (prevents DoS from loading all tickets)
state_ids = Ticket::State.where(name: %w[closed merged removed]).pluck(:id)
ticket = Ticket.where.not(state_id: state_ids)
.where("preferences LIKE ?", "%chat_id: #{params[:group_id]}%")
.order(updated_at: :desc)
.first
unless ticket
Rails.logger.warn "Signal group member joined: Ticket not found for group_id #{params[:group_id]}"
render json: { error: 'Ticket not found for this group' }, status: :not_found
return
end
# Idempotency check: if already marked as joined, skip update and return success
# This prevents unnecessary database writes when the cron job sends duplicate notifications
if ticket.preferences.dig('cdr_signal', 'group_joined') == true
Rails.logger.debug "Signal group member #{params[:member_phone]} already marked as joined for group #{params[:group_id]} ticket #{ticket.id}, skipping update"
render json: {
success: true,
ticket_id: ticket.id,
ticket_number: ticket.number,
group_joined: true,
already_joined: true
}, status: :ok
return
end
# Update group_joined flag
member_phone = params[:member_phone]
ticket.preferences[:cdr_signal][:group_joined] = true
ticket.preferences[:cdr_signal][:group_joined_at] = params[:timestamp] if params[:timestamp].present?
ticket.preferences[:cdr_signal][:group_joined_by] = member_phone
ticket.save!
Rails.logger.info "Signal group member #{member_phone} joined group #{params[:group_id]} for ticket #{ticket.id}"
render json: {
success: true,
ticket_id: ticket.id,
ticket_number: ticket.number,
group_joined: true
}, status: :ok
end
end end

View file

@ -30,25 +30,6 @@ class CommunicateCdrSignalJob < ApplicationJob
log_error(article, log_error(article,
"Can't find ticket.preferences['cdr_signal']['chat_id'] for Ticket.find(#{article.ticket_id})") "Can't find ticket.preferences['cdr_signal']['chat_id'] for Ticket.find(#{article.ticket_id})")
end end
# Check if this is a group chat and if the user has joined
chat_id = ticket.preferences['cdr_signal']['chat_id']
is_group_chat = chat_id&.start_with?('group.')
group_joined = ticket.preferences.dig('cdr_signal', 'group_joined')
# If this is a group chat and user hasn't joined yet, don't send the message
if is_group_chat && group_joined == false
Rails.logger.info "Ticket ##{ticket.number}: User hasn't joined Signal group yet, skipping message delivery"
# Mark article as pending delivery
article.preferences['delivery_status'] = 'pending'
article.preferences['delivery_status_message'] = 'Waiting for user to join Signal group'
article.preferences['delivery_status_date'] = Time.zone.now
article.save!
# Retry later when user might have joined
raise 'User has not joined Signal group yet'
end
channel = ::CdrSignal.bot_by_bot_token(ticket.preferences['cdr_signal']['bot_token']) channel = ::CdrSignal.bot_by_bot_token(ticket.preferences['cdr_signal']['bot_token'])
channel ||= ::Channel.lookup(id: ticket.preferences['channel_id']) channel ||= ::Channel.lookup(id: ticket.preferences['channel_id'])
unless channel unless channel

View file

@ -1,9 +0,0 @@
# frozen_string_literal: true
module Controllers
class CdrSignalChannelsControllerPolicy < Controllers::ApplicationControllerPolicy
def index?
user.permissions?('admin.channel')
end
end
end

View file

@ -1,5 +0,0 @@
Zammad::Application.routes.draw do
api_path = Rails.configuration.api_path
match api_path + '/cdr_signal_channels', to: 'cdr_signal_channels#index', via: :get
end

View file

@ -1,6 +1,6 @@
{ {
"name": "@link-stack/zammad-addon-common", "name": "@link-stack/zammad-addon-common",
"version": "3.3.5", "version": "3.3.0-beta.1",
"description": "", "description": "",
"bin": { "bin": {
"zpm-build": "./dist/build.js", "zpm-build": "./dist/build.js",

View file

@ -1,7 +1,7 @@
{ {
"name": "@link-stack/zammad-addon-hardening", "name": "@link-stack/zammad-addon-hardening",
"displayName": "Hardening", "displayName": "Hardening",
"version": "3.3.5", "version": "3.3.0-beta.1",
"description": "A Zammad addon that hardens a Zammad instance according to CDR's needs.", "description": "A Zammad addon that hardens a Zammad instance according to CDR's needs.",
"scripts": { "scripts": {
"build": "node '../zammad-addon-common/dist/build.js'", "build": "node '../zammad-addon-common/dist/build.js'",

1746
pnpm-lock.yaml generated

File diff suppressed because it is too large Load diff

9
set_channel_setting.rb Normal file
View file

@ -0,0 +1,9 @@
#!/usr/bin/env ruby
require '/opt/zammad/config/boot'
require '/opt/zammad/config/application'
Rails.application.initialize!
Setting.set('cdr_link_allowed_channels', 'note,cdr_signal,email')
puts "Setting 'cdr_link_allowed_channels' has been set to: 'note,cdr_signal,email'"