refactor: enhance error handling

.github/workflows/test.yml

@@ -34,8 +34,8 @@ jobs:
     needs: test
     strategy:
       matrix:
-        os: ['ubuntu-18.04']
-        # os: ['ubuntu-18.04', 'macOS-10.14', 'windows-2019']
+        # os: ['ubuntu-18.04', 'macOS-10.14']
+        os: ['ubuntu-18.04', 'macOS-10.14', 'windows-2019']
         # hugo-version: ['latest']
         # extended: [true]
         hugo-version: ['latest', '0.58.2']

__tests__/get-url.test.js

@@ -2,14 +2,23 @@ const getURL = require("../lib/get-url");
 
 describe("getURL()", () => {
   test("test", () => {
-    const baseURL = "https://github.com/gohugoio/hugo/releases/download/v0.58.2";
+    const baseURL =
+      "https://github.com/gohugoio/hugo/releases/download/v0.58.2";
     const urlLinux = `${baseURL}/hugo_0.58.2_Linux-64bit.tar.gz`;
     const urlLinuxExtended = `${baseURL}/hugo_extended_0.58.2_Linux-64bit.tar.gz`;
     const urlMacOS = `${baseURL}/hugo_0.58.2_macOS-64bit.tar.gz`;
     const urlWindows = `${baseURL}/hugo_0.58.2_Windows-64bit.zip`;
     expect(getURL("Linux", false, "0.58.2")).toBe(urlLinux);
     expect(getURL("Linux", true, "0.58.2")).toBe(urlLinuxExtended);
+    expect(getURL("Linux", "false", "0.58.2")).toBe(urlLinux);
+    expect(getURL("Linux", "true", "0.58.2")).toBe(urlLinux);
     expect(getURL("macOS", false, "0.58.2")).toBe(urlMacOS);
     expect(getURL("Windows", false, "0.58.2")).toBe(urlWindows);
   });
+
+  // test("test exception", () => {
+  //   expect(() => {
+  //     getURL("Linux", "hoge", "0.58.2");
+  //   }).toThrowError("Invalid input (extended): hoge");
+  // });
 });

lib/get-url.js

@@ -1,17 +1,25 @@
 function getURL(os, extended, version) {
-  let extendedStr = "";
-  let ext = "tar.gz";
-
+  const extendedStr = extended => {
     if (extended === true) {
-    extendedStr = "extended_";
+      return "extended_";
+    } else {
+      return "";
+    // } else {
+    //   throw new Error(`Invalid input (extended): ${extended}`);
     }
+  };
 
+  const ext = os => {
     if (os === "Windows") {
-    ext = "zip";
+      return "zip";
+    } else {
+      return "tar.gz";
     }
+  };
 
-  const hugoName = `hugo_${extendedStr}${version}_${os}-64bit`;
-  const url = `https://github.com/gohugoio/hugo/releases/download/v${version}/${hugoName}.${ext}`;
+  const hugoName = `hugo_${extendedStr(extended)}${version}_${os}-64bit`;
+  const baseURL = "https://github.com/gohugoio/hugo/releases/download";
+  const url = `${baseURL}/v${version}/${hugoName}.${ext(os)}`;
 
   return url;
 }

lib/installer.js

@@ -5,6 +5,7 @@ const getOS = require("./get-os");
 const getURL = require("./get-url");
 
 async function installer(version) {
+  try {
     const extended = core.getInput("extended");
     console.log(`Hugo extended: ${extended}`);
 
@@ -29,6 +30,9 @@ async function installer(version) {
       hugoBin = `${hugoExtractedFolder}/hugo`;
     }
     await io.mv(hugoBin, hugoPath);
+  } catch (error) {
+    core.setFailed(error.message);
+  }
 }
 
 module.exports = installer;