Address shellcheck warnings

deb/Dockerfile

@@ -1,16 +1,24 @@
-FROM ubuntu:jammy
+FROM --platform=${BUILDPLATFORM} ubuntu:noble
 LABEL maintainer="Xiaonan Shen <s@sxn.dev>"
 
 EXPOSE 25/tcp
 EXPOSE 143/tcp
 
-
 RUN --mount=target=/var/lib/apt/lists,type=cache,sharing=locked \
     --mount=target=/var/cache/apt,type=cache,sharing=locked \
     rm -f /etc/apt/apt.conf.d/docker-clean \
     && apt-get update \
+    && apt-get upgrade -y \
     && apt-get -y --no-install-recommends install \
-        libc6
+        libc6 \
+        socat \
+        pass \
+        ca-certificates \
+        wget \
+        binutils \
+        xz-utils \
+        libsecret-1-0 \
+        libgl1
 
 WORKDIR /protonmail
 

deb/VERSION

@@ -1 +1 @@
-3.12.0-1
+3.13.0-1

deb/install.sh

@@ -2,35 +2,27 @@
 
 set -ex
 
-VERSION=`cat VERSION`
+VERSION=$(cat VERSION)
 DEB_FILE=protonmail-bridge_${VERSION}_amd64.deb
 
-# Install dependents
-apt-get update
-apt-get install -y --no-install-recommends socat pass ca-certificates
-
-# Build time dependencies
-apt-get install -y wget binutils xz-utils
-
 # Repack deb (remove unnecessary dependencies)
 mkdir deb
 cd deb
-wget -q https://protonmail.com/download/bridge/${DEB_FILE}
-ar x -v ${DEB_FILE}
+wget https://proton.me/download/bridge/"${DEB_FILE}"
+ar x -v "${DEB_FILE}"
 mkdir control
 tar zxvf control.tar.gz -C control
 sed -i "s/^Depends: .*$/Depends: libgl1, libc6, libsecret-1-0, libstdc++6, libgcc1/" control/control
 cd control
 tar zcvf ../control.tar.gz .
 cd ../
-ar rcs -v ${DEB_FILE} debian-binary control.tar.gz data.tar.gz
+ar rcs -v "${DEB_FILE}" debian-binary control.tar.gz data.tar.gz
 cd ../
 
 # Install protonmail bridge
-apt-get install -y --no-install-recommends ./deb/${DEB_FILE}
+apt-get install -y --no-install-recommends ./deb/"${DEB_FILE}"
 
 # Cleanup
 apt-get purge -y wget binutils xz-utils
 apt-get autoremove -y
-rm -rf /var/lib/apt/lists/*
 rm -rf deb