with_items to loop

Signed-off-by: Mark Bolwell <mark.bollyuk@gmail.com>

tasks/section_3/cis_3.1.x.yml

@@ -62,8 +62,7 @@
             mode: "0600"
             owner: root
             group: root
-        with_items:
+        loop: tipc  # note the item used in the template
-            - tipc
 
       - name: "3.1.3 | PATCH | Ensure TIPC is disabled | blacklist"
         ansible.builtin.lineinfile:

tasks/section_3/cis_3.4.1.x.yml

@@ -21,8 +21,7 @@
         ansible.builtin.systemd:
             name: "{{ item }}"
             masked: true
-        with_items:
+        loop: firewalld
-            - firewalld
         when:
             - item in ansible_facts.packages
             - rhel9cis_firewall == 'nftables'
@@ -31,8 +30,7 @@
         ansible.builtin.systemd:
             name: "{{ item }}"
             masked: true
-        with_items:
+        loop: nftables
-            - nftables
         when:
             - item in ansible_facts.packages
             - rhel9cis_firewall == 'firewalld'

tasks/section_3/cis_3.4.2.x.yml

@@ -102,7 +102,7 @@
       - name: "3.4.2.3 | PATCH | Ensure nftables base chains exist | Create chains if needed"
         ansible.builtin.shell: "{{ item }}"
         failed_when: false
-        with_items:
+        loop:
             - nft create chain inet "{{ rhel9cis_nft_tables_tablename }}" input { type filter hook input priority 0 \; }
             - nft create chain inet "{{ rhel9cis_nft_tables_tablename }}" forward { type filter hook forward priority 0 \; }
             - nft create chain inet "{{ rhel9cis_nft_tables_tablename }}" output { type filter hook output priority 0 \; }

tasks/section_4/cis_4.3.yml

@@ -23,7 +23,7 @@
             path: "{{ item.path }}"
             regexp: '^(\s*)(daily|weekly|monthly|yearly)$'
             replace: "\\1{{ rhel9cis_logrotate }}"
-        with_items:
+        loop:
             - "{{ log_rotates.files }}"
             - { path: "/etc/logrotate.conf" }
         loop_control: