Merge branch '201-login-page-misleading-error-message' into 'dev'

fixed: Login error message improved and necessary translation string added

See merge request keanuapp/keanuapp-weblite!31

src/assets/translations/bo.json

@@ -47,7 +47,8 @@
         "password_required": "གསང་ཚིག་དགོས་ཀྱི་ཡོད།",
         "username_required": "སྤྱོད་མིང་དགོས་ཀྱི་ཡོད།",
         "create_room": "ཐོ་འགོད་དང་ཁ་བརྡ་ཁང་གསར་སྐྲུན།",
-        "or": "ཡང་ན།"
+        "or": "ཡང་ན།",
+        "invalid_message": ""
     },
     "new_room": {
         "next": "རྗེས་མ།",

src/assets/translations/de.json

@@ -110,7 +110,8 @@
         "password_required": "Das Passwort ist erforderlich",
         "login": "Anmelden",
         "create_room": "Registrieren und Raum erstellen",
-        "or": "ODER"
+        "or": "ODER",
+        "invalid_message": ""
     },
     "profile": {
         "title": "Mein Profil",

src/assets/translations/en.json

@@ -115,7 +115,8 @@
     "password_required": "Password is required",
     "login": "Login",
     "create_room": "Register & Create Room",
-    "or": "OR"
+    "or": "OR",
+    "invalid_message": "Invalid username or password"
   },
   "profile": {
     "title": "My Profile",

src/assets/translations/es.json

@@ -76,7 +76,8 @@
         "username": "Nombre de Usuario",
         "title": "Iniciar sesión",
         "create_room": "",
-        "or": ""
+        "or": "",
+        "invalid_message": ""
     },
     "device_list": {
         "not_verified": "No ha sido Verificado",

src/assets/translations/fi.json

@@ -60,7 +60,8 @@
         "login": "Kirjaudu sisään",
         "password": "Anna salasana",
         "password_required": "Salasana vaaditaan",
-        "create_room": "Rekisteröidy ja luo huone"
+        "create_room": "Rekisteröidy ja luo huone",
+        "invalid_message": ""
     },
     "join": {
         "joining_as": "Liityt jäsenenä:",

src/assets/translations/fr.json

@@ -110,7 +110,8 @@
         "password_required": "Le mot de passe est obligatoire",
         "create_room": "S’inscrire et créer un salon",
         "or": "OU",
-        "login": "Se connecter"
+        "login": "Se connecter",
+        "invalid_message": ""
     },
     "profile": {
         "temporary_identity": "Cette identité est temporaire. Définissez un mot de passe pour l’utiliser à nouveau",

src/assets/translations/it.json

@@ -109,7 +109,8 @@
         "login": "Accedi",
         "create_room": "Registrati e crea una stanza",
         "or": "O",
-        "username_required": "Il nome utente è richiesto"
+        "username_required": "Il nome utente è richiesto",
+        "invalid_message": ""
     },
     "profile": {
         "title": "Il mio profilo",

src/assets/translations/nb_NO.json

@@ -102,7 +102,8 @@
         "password": "Passord",
         "username": "Brukernavn",
         "create_room": "",
-        "or": ""
+        "or": "",
+        "invalid_message": ""
     },
     "new_room": {
         "add_people": "Legg til folk",

src/assets/translations/pt_BR.json

@@ -128,7 +128,8 @@
         "password_required": "A senha é obrigatória",
         "login": "Entrar",
         "create_room": "Cadastre-se e crie uma sala",
-        "or": "OU"
+        "or": "OU",
+        "invalid_message": ""
     },
     "profile": {
         "title": "Meu perfil",

src/assets/translations/ro.json

@@ -135,7 +135,8 @@
         "username": "Nume utilizator (ex: marta)",
         "title": "Autentificare",
         "create_room": "",
-        "or": ""
+        "or": "",
+        "invalid_message": ""
     },
     "device_list": {
         "not_verified": "Nu a fost verificat",

src/assets/translations/si.json

@@ -23,5 +23,8 @@
         "download_progress": "{percentage}% බාගත වී ඇත",
         "file_prefix": "ගොනුව: ",
         "you": "ඔබ"
+    },
+    "login": {
+        "invalid_message": ""
     }
 }

src/assets/translations/ug.json

@@ -221,7 +221,8 @@
         "username": "قوللانغۇچى ئىسمى (مەسىلەن: marta)",
         "title": "كىرىش",
         "create_room": "",
-        "or": ""
+        "or": "",
+        "invalid_message": ""
     },
     "device_list": {
         "not_verified": "دەلىللەنمىدى",

src/assets/translations/zh_Hans.json

@@ -50,7 +50,8 @@
         "username_required": "需要用户名",
         "username": "用户名 (如: marta)",
         "create_room": "",
-        "or": ""
+        "or": "",
+        "invalid_message": ""
     },
     "device_list": {
         "title": "设备",

src/components/Login.vue

@@ -37,6 +37,7 @@
           :error-messages="userErrorMessage"
           required
           v-on:keyup.enter="$refs.password.focus()"
+          v-on:keydown="hasError=false"
         ></v-text-field>
         <v-text-field
           prepend-inner-icon="$vuetify.icons.password"
@@ -51,6 +52,7 @@
           :error="passErrorMessage != null"
           :error-messages="passErrorMessage"
           required
+          v-on:keydown="hasError=false"
           v-on:keyup.enter="
             () => {
               if (isValid && !loading) {
@@ -59,6 +61,7 @@
             }
           "
         ></v-text-field>
+        <div class="error--text" v-if="hasError">{{ this.message }}</div>
         <v-checkbox
           class="mt-0"
           v-model="rememberMe"
@@ -102,6 +105,7 @@ export default {
       message: "",
       userErrorMessage: null,
       passErrorMessage: null,
+      hasError: false
     };
   },
   computed: {
@@ -142,19 +146,7 @@ export default {
         this.passErrorMessage = null;
       },
       deep: true,
-    },
-    message() {
-      if (this.message && this.message.toLowerCase().includes("user")) {
-        this.userErrorMessage = this.message;
-      } else {
-        this.userErrorMessage = null;
     }
-      if (this.message && this.message.toLowerCase().includes("pass")) {
-        this.passErrorMessage = this.message;
-      } else {
-        this.passErrorMessage = null;
-      }
-    },
   },
   methods: {
     handleLogin() {
@@ -189,6 +181,10 @@ export default {
               (error.data && error.data.error) ||
               error.message ||
               error.toString();
+            if(error.data.errcode ==='M_FORBIDDEN') {
+              this.message = this.$i18n.messages[this.$i18n.locale].login.invalid_message;
+              this.hasError = true;
+            }
             console.log("Message set to ", this.message);
           }
         );