From 2c5b386af9182f4f8624e73b66ad98a3e0391cd5 Mon Sep 17 00:00:00 2001 From: N-Pex Date: Tue, 13 May 2025 16:12:05 +0200 Subject: [PATCH] Vue lifecycle changes destroyed -> unmounted, beforeDestroy -> beforeUnmount --- src/components/AudioLayout.vue | 2 +- src/components/AuthedImage.vue | 2 +- src/components/BottomSheet.vue | 2 +- src/components/Chat.vue | 4 ++-- src/components/ChatHeader.vue | 2 +- src/components/Join.vue | 2 +- src/components/RoomInfo.vue | 2 +- src/components/file_mode/FileDropLayout.vue | 2 +- src/components/file_mode/GalleryItemsView.vue | 2 +- src/components/messages/AudioPlayer.vue | 2 +- src/components/messages/QuickReactions.vue | 2 +- src/components/messages/SeenBy.vue | 2 +- src/components/messages/attachmentMixin.js | 2 +- src/components/messages/channel/QuickReactionsChannel.vue | 2 +- src/components/messages/pollMixin.js | 4 ++-- src/components/roomInfoMixin.js | 2 +- src/components/roomMembersMixin.js | 2 +- src/components/roomTypeMixin.js | 2 +- 18 files changed, 20 insertions(+), 20 deletions(-) diff --git a/src/components/AudioLayout.vue b/src/components/AudioLayout.vue index 9e110fb..bb73f35 100644 --- a/src/components/AudioLayout.vue +++ b/src/components/AudioLayout.vue @@ -139,7 +139,7 @@ export default { document.body.classList.add("dark"); this.$audioPlayer.setAutoplay(false); }, - beforeDestroy() { + beforeUnmount() { emitter.off('audio-playback-started', this.audioPlaybackStarted); emitter.off('audio-playback-paused', this.audioPlaybackPaused); emitter.off('audio-playback-ended', this.audioPlaybackEnded); diff --git a/src/components/AuthedImage.vue b/src/components/AuthedImage.vue index 92b5b40..9c94e73 100644 --- a/src/components/AuthedImage.vue +++ b/src/components/AuthedImage.vue @@ -15,7 +15,7 @@ export default { }, }, }, - destroyed() { + unmounted() { this.unloadSrc(); }, watch: { diff --git a/src/components/BottomSheet.vue b/src/components/BottomSheet.vue index 318f2ad..10d9dab 100644 --- a/src/components/BottomSheet.vue +++ b/src/components/BottomSheet.vue @@ -114,7 +114,7 @@ export default { } }); }, - beforeDestroy() { + beforeUnmount() { this.mc.destroy(); window.onresize = null; }, diff --git a/src/components/Chat.vue b/src/components/Chat.vue index 567a5e9..f497cbd 100644 --- a/src/components/Chat.vue +++ b/src/components/Chat.vue @@ -561,7 +561,7 @@ export default { } }, - beforeDestroy() { + beforeUnmount() { emitter.off('audio-playback-ended', this.audioPlaybackEnded); this.$audioPlayer.pause(); this.stopRRTimer(); @@ -571,7 +571,7 @@ export default { } }, - destroyed() { + unmounted() { this.$matrix.off("Room.timeline", this.onEvent); this.$matrix.off("RoomMember.typing", this.onUserTyping); }, diff --git a/src/components/ChatHeader.vue b/src/components/ChatHeader.vue index fc8ffdd..b775c8c 100644 --- a/src/components/ChatHeader.vue +++ b/src/components/ChatHeader.vue @@ -101,7 +101,7 @@ export default { this.updateMemberCount(); }, - destroyed() { + unmounted() { this.$matrix.off("Room.timeline", this.onEvent); }, diff --git a/src/components/Join.vue b/src/components/Join.vue index 3fc2787..27dd270 100644 --- a/src/components/Join.vue +++ b/src/components/Join.vue @@ -467,7 +467,7 @@ export default { // action and set up conversion tracking triggered by Room Joined (once per visit). this.$analytics.event("Invitations", "Join Page Shown"); }, - destroyed() { + unmounted() { this.$matrix.off("Room.myMembership", this.onMyMembership); }, }; diff --git a/src/components/RoomInfo.vue b/src/components/RoomInfo.vue index 68a9ff6..eb0502c 100644 --- a/src/components/RoomInfo.vue +++ b/src/components/RoomInfo.vue @@ -353,7 +353,7 @@ export default { this.buildVersion = buildVersion; }, - destroyed() { + unmounted() { this.$matrix.off("Room.timeline", this.onEvent); }, diff --git a/src/components/file_mode/FileDropLayout.vue b/src/components/file_mode/FileDropLayout.vue index 897006c..eb417c6 100644 --- a/src/components/file_mode/FileDropLayout.vue +++ b/src/components/file_mode/FileDropLayout.vue @@ -136,7 +136,7 @@ export default { document.body.classList.add("dark"); this.$audioPlayer.setAutoplay(false); }, - beforeDestroy() { + beforeUnmount() { document.body.classList.remove("dark"); }, computed: { diff --git a/src/components/file_mode/GalleryItemsView.vue b/src/components/file_mode/GalleryItemsView.vue index 8d8322a..418e26d 100644 --- a/src/components/file_mode/GalleryItemsView.vue +++ b/src/components/file_mode/GalleryItemsView.vue @@ -65,7 +65,7 @@ export default { } } }, - beforeDestroy() { + beforeUnmount() { document.body.classList.remove("dark"); }, computed: { diff --git a/src/components/messages/AudioPlayer.vue b/src/components/messages/AudioPlayer.vue index f0194b3..9f64cfc 100644 --- a/src/components/messages/AudioPlayer.vue +++ b/src/components/messages/AudioPlayer.vue @@ -44,7 +44,7 @@ export default { mounted() { this.event.on("Event.localEventIdReplaced", this.onLocalEventIdReplaced); }, - beforeDestroy() { + beforeUnmount() { this.$audioPlayer.removeListener(this._uid); this.event.off("Event.localEventIdReplaced", this.onLocalEventIdReplaced); }, diff --git a/src/components/messages/QuickReactions.vue b/src/components/messages/QuickReactions.vue index 6ba4e92..c3aa40c 100644 --- a/src/components/messages/QuickReactions.vue +++ b/src/components/messages/QuickReactions.vue @@ -86,7 +86,7 @@ export default { this.reactions = this.timelineSet.relations.getChildEventsForEvent(this.event.getId(), 'm.annotation', 'm.reaction'); this.event.on("Event.relationsCreated", this.onRelationsCreated); }, - beforeDestroy() { + beforeUnmount() { this.event.off("Event.relationsCreated", this.onRelationsCreated); if (this.reactions) { this.reactions.off('Relations.add', this.onAddRelation); diff --git a/src/components/messages/SeenBy.vue b/src/components/messages/SeenBy.vue index b97ca3d..8fe2f1b 100644 --- a/src/components/messages/SeenBy.vue +++ b/src/components/messages/SeenBy.vue @@ -79,7 +79,7 @@ export default { this.room.on("Room.receipt", this.onReceipt); } }, - beforeDestroy() { + beforeUnmount() { if (this.room) { this.room.off("Room.receipt", this.onReceipt); } diff --git a/src/components/messages/attachmentMixin.js b/src/components/messages/attachmentMixin.js index 4a9a4fa..5379834 100644 --- a/src/components/messages/attachmentMixin.js +++ b/src/components/messages/attachmentMixin.js @@ -19,7 +19,7 @@ export default { mounted() { this.loadAttachmentSource(this.event); }, - beforeDestroy() { + beforeUnmount() { this.loadAttachmentSource(null); // Release }, computed: { diff --git a/src/components/messages/channel/QuickReactionsChannel.vue b/src/components/messages/channel/QuickReactionsChannel.vue index 87086be..0817304 100644 --- a/src/components/messages/channel/QuickReactionsChannel.vue +++ b/src/components/messages/channel/QuickReactionsChannel.vue @@ -50,7 +50,7 @@ export default { this.reactions = this.timelineSet.relations.getChildEventsForEvent(this.event.getId(), 'm.annotation', 'm.reaction'); this.event.on("Event.relationsCreated", this.onRelationsCreated); }, - beforeDestroy() { + beforeUnmount() { this.event.off("Event.relationsCreated", this.onRelationsCreated); if (this.reactions) { this.reactions.off('Relations.add', this.onAddRelation); diff --git a/src/components/messages/pollMixin.js b/src/components/messages/pollMixin.js index b1da22f..5761fa3 100644 --- a/src/components/messages/pollMixin.js +++ b/src/components/messages/pollMixin.js @@ -26,10 +26,10 @@ export default { ""; this.updateAnswers(); }, - destroyed() { + unmounted() { this.$matrix.off("Room.timeline", this.pollMixinOnEvent); }, - beforeDestroy() { + beforeUnmount() { if (this.pollResponseRelations) { this.pollResponseRelations.off("Relations.add", this.onAddRelation); this.pollResponseRelations = null; diff --git a/src/components/roomInfoMixin.js b/src/components/roomInfoMixin.js index f3862be..04dc632 100644 --- a/src/components/roomInfoMixin.js +++ b/src/components/roomInfoMixin.js @@ -24,7 +24,7 @@ export default { this.updateMessageRetention(); }, - destroyed() { + unmounted() { this.$matrix.off("Room.timeline", this.roomInfoMixinOnEvent); }, diff --git a/src/components/roomMembersMixin.js b/src/components/roomMembersMixin.js index ac5ec09..71e79a9 100644 --- a/src/components/roomMembersMixin.js +++ b/src/components/roomMembersMixin.js @@ -9,7 +9,7 @@ export default { this.updateMembers(); }, - destroyed() { + unmounted() { this.$matrix.off("Room.timeline", this.roomMembersMixinOnEvent); }, diff --git a/src/components/roomTypeMixin.js b/src/components/roomTypeMixin.js index 5b6ce3e..1f94a38 100644 --- a/src/components/roomTypeMixin.js +++ b/src/components/roomTypeMixin.js @@ -9,7 +9,7 @@ export default { mounted() { this.$matrix.on("Room.timeline", this.onRoomTypeMixinEvent); }, - destroyed() { + unmounted() { this.$matrix.off("Room.timeline", this.onRoomTypeMixinEvent); }, watch: {