8fff0e887c
* Update gometalinter config gometalinter now uses `maligned` instead of `aligncheck` (https://github.com/alecthomas/gometalinter/pull/367), so we need to update our config accordingly. * Update gometalinter * Disable gotype linter gotype does not seem to play nicely with the gb vendor directory. In particular, it wants each of our dependencies to be built and installed (see https://github.com/golang/go/issues/10969), but (empirically) it will not accept them being installed in `pkg` but insists on them being in `vendor/pkg`. This presents a problem because `gb build` builds the packages into `pkg` (which doesn't seem entirely unreasonable since `.` comes before `vendor` in `$GOPATH`). `go install github.com/x/y` does install in `vendor/pkg` but requires us to know the name of each package. The general conclusion of https://github.com/alecthomas/gometalinter/issues/91 seems to have been that the easiest thing to do is to disable `gotype` for now. * Fix `unparam` lint * Fix goshadow lint
66 lines
1.4 KiB
Go
66 lines
1.4 KiB
Go
package main
|
|
|
|
import (
|
|
"encoding/xml"
|
|
"fmt"
|
|
|
|
kingpin "gopkg.in/alecthomas/kingpin.v3-unstable"
|
|
)
|
|
|
|
type checkstyleOutput struct {
|
|
XMLName xml.Name `xml:"checkstyle"`
|
|
Version string `xml:"version,attr"`
|
|
Files []*checkstyleFile `xml:"file"`
|
|
}
|
|
|
|
type checkstyleFile struct {
|
|
Name string `xml:"name,attr"`
|
|
Errors []*checkstyleError `xml:"error"`
|
|
}
|
|
|
|
type checkstyleError struct {
|
|
Column int `xml:"column,attr"`
|
|
Line int `xml:"line,attr"`
|
|
Message string `xml:"message,attr"`
|
|
Severity string `xml:"severity,attr"`
|
|
Source string `xml:"source,attr"`
|
|
}
|
|
|
|
func outputToCheckstyle(issues chan *Issue) int {
|
|
var lastFile *checkstyleFile
|
|
out := checkstyleOutput{
|
|
Version: "5.0",
|
|
}
|
|
status := 0
|
|
for issue := range issues {
|
|
if lastFile != nil && lastFile.Name != issue.Path {
|
|
out.Files = append(out.Files, lastFile)
|
|
lastFile = nil
|
|
}
|
|
if lastFile == nil {
|
|
lastFile = &checkstyleFile{
|
|
Name: issue.Path,
|
|
}
|
|
}
|
|
|
|
if config.Errors && issue.Severity != Error {
|
|
continue
|
|
}
|
|
|
|
lastFile.Errors = append(lastFile.Errors, &checkstyleError{
|
|
Column: issue.Col,
|
|
Line: issue.Line,
|
|
Message: issue.Message,
|
|
Severity: string(issue.Severity),
|
|
Source: issue.Linter,
|
|
})
|
|
status = 1
|
|
}
|
|
if lastFile != nil {
|
|
out.Files = append(out.Files, lastFile)
|
|
}
|
|
d, err := xml.Marshal(&out)
|
|
kingpin.FatalIfError(err, "")
|
|
fmt.Printf("%s%s\n", xml.Header, d)
|
|
return status
|
|
}
|