From baeba7a8a7c26ec62b2828fcff8e1e934fd01399 Mon Sep 17 00:00:00 2001 From: peaceiris <30958501+peaceiris@users.noreply.github.com> Date: Mon, 16 Sep 2019 05:59:37 +0900 Subject: [PATCH] remove: reject --- get-latest-version.js | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/get-latest-version.js b/get-latest-version.js index 4670f6a..738e4f1 100644 --- a/get-latest-version.js +++ b/get-latest-version.js @@ -1,11 +1,7 @@ const XMLHttpRequest = require("xmlhttprequest").XMLHttpRequest; function getLatestVersion() { - return new Promise((resolve, reject) => { - // if (typeof milliseconds !== "number") { - // throw new Error("milleseconds not a number"); - // } - + return new Promise((resolve) => { const xhr = new XMLHttpRequest(); const url = "https://api.github.com/repos/gohugoio/hugo/releases/latest"; xhr.open("GET", url); @@ -18,8 +14,9 @@ function getLatestVersion() { const latestVersion = latestURL.match(/(\d+).(\d+).(\d+)/g)[0]; resolve(latestVersion); - } else if (xhr.status !== 200) { - reject(`ERROR: got status ${xhr.status}`); + } else { + throw new Error(`ERROR: got status ${xhr.status}`); + // reject(`ERROR: got status ${xhr.status}`); } }; });