From 947ed8e60f943e61e5366597434fccaaae0223a6 Mon Sep 17 00:00:00 2001 From: peaceiris <30958501+peaceiris@users.noreply.github.com> Date: Wed, 18 Sep 2019 03:15:02 +0900 Subject: [PATCH] refactor: enhance error message of promise reject --- .github/workflows/test.yml | 6 ++++-- get-latest-version.js | 3 +-- index.js | 5 ++--- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index d5dc51b..ad22387 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -27,8 +27,10 @@ jobs: needs: test strategy: matrix: - hugo-version: ['latest', '0.58.2'] - extended: [true, false] + hugo-version: ['latest'] + extended: [true] + # hugo-version: ['latest', '0.58.2'] + # extended: [true, false] steps: - uses: actions/checkout@v1 diff --git a/get-latest-version.js b/get-latest-version.js index 6fe7d5d..e3bdcd3 100644 --- a/get-latest-version.js +++ b/get-latest-version.js @@ -6,14 +6,13 @@ function getLatestVersion() { const url = "https://formulae.brew.sh/api/formula/hugo.json"; xhr.open("GET", url); xhr.send(); - xhr.onreadystatechange = function() { if (xhr.readyState === 4 && xhr.status === 200) { const result = JSON.parse(xhr.responseText); const latestVersion = result.versions.stable; resolve(latestVersion); } else if (xhr.readyState === 4 && xhr.status !== 200) { - reject(`ERROR: got status ${xhr.status}`); + reject(`ERROR: got status ${xhr.status} of ${url}`); } }; }); diff --git a/index.js b/index.js index 890028d..80a0404 100644 --- a/index.js +++ b/index.js @@ -14,9 +14,8 @@ async function run() { } console.log(`Hugo version: ${hugoVersion}`); - let extended = core.getInput("extended"); + const extended = core.getInput("extended"); console.log(`Hugo extended: ${extended}`); - let extendedStr = ""; if (extended === "true") { extendedStr = "extended_"; @@ -41,7 +40,7 @@ async function run() { await io.mv(`${hugoExtractedFolder}/hugo`, hugoPath); }, function(error) { - console.error(error); + core.setFailed(error); } ); } catch (error) {