From 7a226588c6f5f1c735cf30e37c1465c1e00bb209 Mon Sep 17 00:00:00 2001 From: peaceiris <30958501+peaceiris@users.noreply.github.com> Date: Wed, 18 Sep 2019 02:00:57 +0900 Subject: [PATCH] feat: Add reject to Promise --- get-latest-version.js | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/get-latest-version.js b/get-latest-version.js index c8552ae..6fe7d5d 100644 --- a/get-latest-version.js +++ b/get-latest-version.js @@ -1,8 +1,7 @@ const XMLHttpRequest = require("xmlhttprequest").XMLHttpRequest; function getLatestVersion() { - // return new Promise((resolve, reject) => { - return new Promise(resolve => { + return new Promise((resolve, reject) => { const xhr = new XMLHttpRequest(); const url = "https://formulae.brew.sh/api/formula/hugo.json"; xhr.open("GET", url); @@ -13,8 +12,8 @@ function getLatestVersion() { const result = JSON.parse(xhr.responseText); const latestVersion = result.versions.stable; resolve(latestVersion); - // } else { - // reject(`ERROR: got status ${xhr.status}`); + } else if (xhr.readyState === 4 && xhr.status !== 200) { + reject(`ERROR: got status ${xhr.status}`); } }; });